[Mesa-dev] [PATCH 3/3] intel: Clean up confusion between logical and physical surface dimensions.

[Paul Berry]

On 10 January 2013 18:12, Eric Anholt <eric at anholt.net> wrote:

> Paul Berry <stereotype441 at gmail.com> writes:
>
> > On 10 January 2013 12:01, Ian Romanick <idr at freedesktop.org> wrote:
> >
> >> On 01/08/2013 02:27 PM, Paul Berry wrote:
> >> This is basically converting depth0 from logical to physical.  We had
> >> discussed that this could cause problems with future cubemap arrays.  I
> may
> >> not be following the code completely, but does this potential future
> >> problem still loom?
> >>
> >>
> > I think we're ok w.r.t. cubemap arrays.  Once we get around to supporting
> > them, all we should have to do is remove the "assert(depth0 == 1)" line
> and
> > replace "depth0 = 6" with "depth0 *= 6".
>
> "get around to supporting them"?  We have GL_ARB_texture_cube_map_array
> as of december.
>

Yeah, Ken pointed out my mistake at the office today.  What's weird is that
the depth0 == 1 assertion pre-dated my patch series, which makes me wonder,
do they work?  Do we have tests for them?  It's hard for me to imagine how
they could possibly work with this assertion present.  I'll look into this
first thing tomorrow.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130110/838fd742/attachment.html>