[Mesa-dev] [PATCH] mesa: expose ARB_seamless_cubemap_per_texture when supported

Ilia Mirkin imirkin at alum.mit.edu
Thu Jun 26 09:53:11 PDT 2014


On Sun, Jun 22, 2014 at 1:49 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> All of the bits appear to already be in place to support this in the
> sampler (which the original AMD version didn't allow).
>
> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
> ---
>
> I'm probably missing some reason why this wasn't already enabled, but sending
> this out anyways. Feel free to point out the error in my reasoning :)

Actualy I noticed a semi-similar patch was sent out nearly a year ago:

http://lists.freedesktop.org/archives/mesa-dev/2013-August/043652.html

To which Ken's response was:

http://lists.freedesktop.org/archives/mesa-dev/2013-August/043660.html

after which I guess the ball got dropped...

Ken, is my patch OK then? Or should I do a s/AMD/ARB/ throughout the
tree as well? Or some third option :)

  -ilia

>
>  src/mesa/main/extensions.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c
> index 25e3dab..522f5ad 100644
> --- a/src/mesa/main/extensions.c
> +++ b/src/mesa/main/extensions.c
> @@ -136,6 +136,7 @@ static const struct extension extension_table[] = {
>     { "GL_ARB_sample_shading",                      o(ARB_sample_shading),                      GL,             2009 },
>     { "GL_ARB_sampler_objects",                     o(dummy_true),                              GL,             2009 },
>     { "GL_ARB_seamless_cube_map",                   o(ARB_seamless_cube_map),                   GL,             2009 },
> +   { "GL_ARB_seamless_cubemap_per_texture",        o(AMD_seamless_cubemap_per_texture),        GL,             2013 },
>     { "GL_ARB_separate_shader_objects",             o(dummy_true),                              GL,             2010 },
>     { "GL_ARB_shader_atomic_counters",              o(ARB_shader_atomic_counters),              GL,             2011 },
>     { "GL_ARB_shader_bit_encoding",                 o(ARB_shader_bit_encoding),                 GL,             2010 },
> --
> 1.8.5.5
>


More information about the mesa-dev mailing list