[Mesa-dev] [PATCH] mesa: expose ARB_seamless_cubemap_per_texture when supported

Kenneth Graunke kenneth at whitecape.org
Thu Jun 26 10:13:17 PDT 2014


On Thursday, June 26, 2014 12:53:11 PM Ilia Mirkin wrote:
> On Sun, Jun 22, 2014 at 1:49 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> > All of the bits appear to already be in place to support this in the
> > sampler (which the original AMD version didn't allow).
> >
> > Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
> > ---
> >
> > I'm probably missing some reason why this wasn't already enabled, but 
sending
> > this out anyways. Feel free to point out the error in my reasoning :)
> 
> Actualy I noticed a semi-similar patch was sent out nearly a year ago:
> 
> http://lists.freedesktop.org/archives/mesa-dev/2013-August/043652.html
> 
> To which Ken's response was:
> 
> http://lists.freedesktop.org/archives/mesa-dev/2013-August/043660.html
> 
> after which I guess the ball got dropped...
> 
> Ken, is my patch OK then? Or should I do a s/AMD/ARB/ throughout the
> tree as well? Or some third option :)
> 
>   -ilia

Yeah, I'm happy to see this land as is.  I'd be in favor of s/AMD/ARB/ in a 
follow-up patch, since the ARB extension is (slight) superset of the AMD one.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140626/884979d8/attachment.sig>


More information about the mesa-dev mailing list