[Mesa-dev] [PATCH 3/5] i965: Use a uniform for gl_PatchVerticesIn in the TES.

Alejandro Piñeiro apinheiro at igalia.com
Wed Jun 8 17:45:30 UTC 2016


On 02/06/16 23:09, Kenneth Graunke wrote:
> Fixes GL44-CTS.tessellation_shader.single.max_patch_vertices,
> which uses gl_PatchVerticesIn in the TES, but doesn't link against
> a TCS (which would allow the linker to lower it to a constant).

Not sure if using different CTS releases but in my case I tested that
this patch (plus the previous one) fixes the following CTS test:
GL44-CTS.tessellation_shader.max_patch_vertices (without the single).

>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> Cc: mesa-stable at lists.freedesktop.org
> ---
>  src/mesa/drivers/dri/i965/brw_context.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c
> index 97dc226..aad2afb 100644
> --- a/src/mesa/drivers/dri/i965/brw_context.c
> +++ b/src/mesa/drivers/dri/i965/brw_context.c
> @@ -599,6 +599,7 @@ brw_initialize_context_constants(struct brw_context *brw)
>        ctx->Const.MaxClipPlanes = 8;
>  
>     ctx->Const.LowerTessLevel = true;
> +   ctx->Const.LowerTESPatchVerticesIn = true;
>     ctx->Const.PrimitiveRestartForPatches = true;
>  
>     ctx->Const.Program[MESA_SHADER_VERTEX].MaxNativeInstructions = 16 * 1024;

Nitpicks apart:
Reviewed-by: Alejandro Piñeiro <apinheiro at igalia.com>



More information about the mesa-dev mailing list