dri-devel April 2021

dri-devel@lists.freedesktop.org

317 participants
715 discussions

[PATCH 0/5] drm/msm: add MSM_BO_CACHED_COHERENT (and related changes)
by Jonathan Marek 02 May '21

02 May '21

Add support for MSM_BO_CACHED_COHERENT, a coherent version of MSM_BO_CACHED which is implemented by setting the IOMMU_CACHE flag. Jonathan Marek (5): drm/msm: remove unnecessary mmap logic for cached BOs drm/msm: replace MSM_BO_UNCACHED with MSM_BO_WC for internal objects drm/msm: use the right pgprot when mapping BOs in the kernel drm/msm: add MSM_BO_CACHED_COHERENT drm/msm: deprecate MSM_BO_UNCACHED (map as writecombine instead) drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 4 +-- drivers/gpu/drm/msm/adreno/a5xx_power.c | 2 +- drivers/gpu/drm/msm/adreno/a5xx_preempt.c | 4 +-- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 2 +- drivers/gpu/drm/msm/adreno/adreno_device.c | 1 + drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +- drivers/gpu/drm/msm/msm_drv.c | 3 +- drivers/gpu/drm/msm/msm_drv.h | 1 + drivers/gpu/drm/msm/msm_gem.c | 34 ++++++++++----------- include/uapi/drm/msm_drm.h | 7 ++--- 12 files changed, 33 insertions(+), 31 deletions(-) -- 2.26.1

2 9

[PATCH 0/6] drm/msm: Trim down drm debugging logs
by Stephen Boyd 30 Apr '21

30 Apr '21

This patch series attempts to trim down the drm logging in the msm driver to make it useable with DRM_UT_DRIVER, DRM_UT_KMS, and DRM_UT_DP levels enabled. Right now the log is really spammy and prints multiple lines for what feels like every frame. I moved those prints off to other DRM_UT_* levels that felt appropriate. Please review. Cc: Dmitry Baryshkov <dmitry.baryshkov(a)linaro.org> Cc: Abhinav Kumar <abhinavk(a)codeaurora.org> Cc: Kuogee Hsieh <khsieh(a)codeaurora.org> Cc: aravindh(a)codeaurora.org Cc: Sean Paul <sean(a)poorly.run> Stephen Boyd (6): drm/msm: Move vblank debug prints to drm_dbg_vbl() drm/msm: Use VERB() for extra verbose logging drm/msm/dp: Drop malformed debug print drm/msm: Move FB debug prints to drm_dbg_state() drm/msm/disp: Use plane debug print helper drm/msm/disp: Move various debug logs to atomic bucket drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c | 16 ++++---- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 22 +++++------ drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 38 +++++++++---------- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 10 ++--- .../drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 6 +-- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 19 ++++------ drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c | 14 +++---- drivers/gpu/drm/msm/dp/dp_panel.c | 1 - drivers/gpu/drm/msm/msm_drv.c | 4 +- drivers/gpu/drm/msm/msm_fb.c | 8 ++-- 12 files changed, 67 insertions(+), 75 deletions(-) base-commit: 9f4ad9e425a1d3b6a34617b8ea226d56a119a717 -- https://chromeos.dev

2 7

[PATCH v1 0/1] drm/dp_mst: Use the correct max source link rate for i915
by Nikola Cornij 30 Apr '21

30 Apr '21

This is a follow-up change to fix incorrectly used max link rate source capability at MST init time. Change history: v1: - Initial Nikola Cornij (1): drm/dp_mst: Use the correct max source link rate for i915 drivers/gpu/drm/i915/display/intel_dp_mst.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) -- 2.25.1

2 2

[git pull] drm tegra-next + fixes for 5.13-rc1
by Dave Airlie 30 Apr '21

30 Apr '21

Hi Linus, Looks like I missed a tegra feature request for next, but should still be fine since it's pretty self contained. It does contain one fixes->next merge with no merge justification so I've pushed back on Thierry about not doing that in the future, but let it go now as rebasing might be worse. Apart from that got a set of i915 and amdgpu fixes as per usual along with a few misc fixes. Dave. drm-next-2021-04-30: drm tegra-next + fixes for 5.13-rc1 tegra: - Tegra186 hardware cursor support - better capability reporting for different SoC - better framebuffer modifier support - host1x fixes ttm: - fix unswappable BO handling efifb: - check for PCI before using it amdgpu: - Fixes for Aldebaran - Display LTTPR fixes - eDP fixes - Fixes for Vangogh - RAS fixes - ASPM support - Renoir SMU fixes - Modifier fixes - Misc code cleanups - Freesync fixes i915: - Several fixes to GLK handling in recent display refactoring - Rare watchdog timer race fix - Cppcheck redundant condition fix - Overlay error code propagation fix - Documentation fix - gvt: Remove one unused function warning - gvt: Fix intel_gvt_init_device() return type - gvt: Remove one duplicated register accessible check The following changes since commit a1a1ca70deb3ec600eeabb21de7f3f48aaae5695: Merge tag 'drm-misc-next-fixes-2021-04-22' of git://anongit.freedesktop.org/drm/drm-misc into drm-next (2021-04-23 13:53:07 +1000) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm tags/drm-next-2021-04-30 for you to fetch changes up to 1cd6b4a04f038eb24fd18c8010e763d1140a9c7a: Merge tag 'drm-intel-next-fixes-2021-04-27' of git://anongit.freedesktop.org/drm/drm-intel into drm-next (2021-04-30 10:42:03 +1000) ---------------------------------------------------------------- drm tegra-next + fixes for 5.13-rc1 tegra: - Tegra186 hardware cursor support - better capability reporting for different SoC - better framebuffer modifier support - host1x fixes ttm: - fix unswappable BO handling efifb: - check for PCI before using it amdgpu: - Fixes for Aldebaran - Display LTTPR fixes - eDP fixes - Fixes for Vangogh - RAS fixes - ASPM support - Renoir SMU fixes - Modifier fixes - Misc code cleanups - Freesync fixes i915: - Several fixes to GLK handling in recent display refactoring - Rare watchdog timer race fix - Cppcheck redundant condition fix - Overlay error code propagation fix - Documentation fix - gvt: Remove one unused function warning - gvt: Fix intel_gvt_init_device() return type - gvt: Remove one duplicated register accessible check ---------------------------------------------------------------- Alex Deucher (1): drm/amdgpu/gmc9: remove dummy read workaround for newer chips Anthony Koo (3): drm/amd/display: [FW Promotion] Release 0.0.60 drm/amd/display: [FW Promotion] Release 0.0.61 drm/amd/display: [FW Promotion] Release 0.0.62 Anthony Wang (3): drm/amd/display: Force vsync flip when reconfiguring MPCC drm/amd/display: Add DSC check to seamless boot validation drm/amd/display: disable seamless boot for external DP Aric Cyr (3): drm/amd/display: 3.2.131 drm/amd/display: Fix FreeSync when RGB MPO in use drm/amd/display: 3.2.132 Bing Guo (1): drm/amd/display: add helper for enabling mst stream features Dan Carpenter (4): drm/i915/gvt: Fix error code in intel_gvt_init_device() drm/amdgpu: fix an error code in init_pmu_entry_by_type_and_add() drm/amd/pm: fix error code in smu_set_power_limit() drm/i915: fix an error code in intel_overlay_do_put_image() Dave Airlie (4): Merge tag 'drm/tegra/for-5.13-rc1' of ssh://git.freedesktop.org/git/tegra/linux into drm-next Merge tag 'drm-misc-next-fixes-2021-04-29' of git://anongit.freedesktop.org/drm/drm-misc into drm-next Merge tag 'amd-drm-next-5.13-2021-04-23' of https://gitlab.freedesktop.org/agd5f/linux into drm-next Merge tag 'drm-intel-next-fixes-2021-04-27' of git://anongit.freedesktop.org/drm/drm-intel into drm-next David Galiffi (1): drm/amd/display: Fixed typo in function name. Dennis Li (2): drm/amdkfd: add edc error interrupt handle for poison propogate mode drm/amdgpu: fix a error injection failed issue Dillon Varone (2): drm/amd/display: Fix call to pass bpp in 16ths of a bit drm/amd/display: Report Proper Quantization Range in AVI Infoframe Dingchen (David) Zhang (2): drm/amd/display: update hdcp display using correct CP type. drm/amd/display: add handling for hdcp2 rx id list validation Eric Huang (1): drm/amdkfd: change MTYPEs for Aldebaran's HW requirement Felix Kuehling (1): drm/amdkfd: Remove legacy code not acquiring VMs Harry Wentland (1): drm/amd/display: Add debugfs to repress HPD and HPR_RX IRQs Hawking Zhang (3): drm/amdgpu: correct default gfx wdt timeout setting drm/amdgpu: only harvest gcea/mmea error status in arcturus drm/amdgpu: only harvest gcea/mmea error status in aldebaran Huang Rui (1): drm/amdgpu: enable tmz on renoir asics Hugo Hu (1): drm/amd/display: treat memory as a single-channel for asymmetric memory v2 Jack Zhang (1): drm/amd/sriov no need to config GECC for sriov Jake Wang (1): drm/amd/display: Added support for multiple eDP BL control Jani Nikula (1): Merge tag 'gvt-next-fixes-2021-04-21' of https://github.com/intel/gvt-linux into drm-intel-next-fixes Jiansong Chen (1): drm/amdgpu: fix GCR_GENERAL_CNTL offset for dimgrey_cavefish Jiapeng Chong (1): drm/i915/gvt: remove useless function Jinzhou Su (2): drm/amdgpu: Add graphics cache rinse packet for sdma drm/amdgpu: Add mem sync flag for IB allocated by SA John Clements (3): drm/amdgpu: update mmhub 1.7 ras error reporting drm/amdgpu: update gfx 9.4.2 ras error reporting drm/amdgpu: resolve erroneous gfx_v9_4_2 prints Jon Hunter (1): gpu: host1x: Fix Tegra194 syncpt interrupt threshold Joseph Greathouse (1): drm/amdgpu: Copy MEC FW version to MEC2 if we skipped loading MEC2 José Roberto de Souza (1): drm/i915/display/psr: Fix cppcheck warnings Kai-Heng Feng (1): efifb: Check efifb_pci_dev before using it Kenneth Feng (3): drm/amd/amdgpu: enable ASPM on navi1x drm/amd/amdgpu: enable ASPM on vega drm/amd/amdgpu: add ASPM support on polaris Kent Russell (1): drm/amdgpu: Ensure dcefclk isn't created on Aldebaran Lewis Huang (1): drm/amd/display: wait vblank when stream enabled and update dpp clock Lijo Lazar (2): drm/amd/pm: Use VBIOS PPTable for aldebaran drm/amd/pm: Show updated clocks on aldebaran Luben Tuikov (5): drm/amdgpu: Fix a bug for input with double sscanf drm/amdgpu: Fix a bug in checking the result of reserve page drm/amdgpu: Add bad_page_cnt_threshold to debugfs drm/amdgpu: Fix kernel-doc for the RAS sysfs interface drm/amdgpu: Add double-sscanf but invert Maarten Lankhorst (1): drm/i915: Fix docbook descriptions for i915_gem_shrinker Michael Strauss (4): drm/amd/display: Add debug flag to enable eDP ILR by default drm/amd/display: Disable boot optimizations if ILR optimzation is required drm/amd/display: Remove static property from decide_edp_link_settings drm/amd/display: Add link rate optimization logs for ILR Mike Hsieh (1): drm/amd/display: Fix DSC enable sequence Mikita Lipski (2): drm/amd/display: Remove unused flag from stream state drm/amd/display: Connect clock optimization function to dcn301 Mikko Perttunen (8): gpu: host1x: Allow syncpoints without associated client gpu: host1x: Show number of pending waiters in debugfs gpu: host1x: Remove cancelled waiters immediately gpu: host1x: Use HW-equivalent syncpoint expiration check gpu: host1x: Cleanup and refcounting for syncpoints gpu: host1x: Reset max value when freeing a syncpoint gpu: host1x: Reserve VBLANK syncpoints at initialization gpu: host1x: Assign intr waiter inside lock Mukul Joshi (2): drm/amdgpu: Reset RAS error count and status regs drm/amdgpu: Fix SDMA RAS error reporting on Aldebaran Nicholas Kazlauskas (2): drm/amd/display: Fix DML validation of simple vs native 422 modes drm/amd/display: Always poll for rxstatus in authenticate Oak Zeng (4): drm/amdgpu: Introduce functions for vram physical addr calculation drm/amdgpu: Calling address translation functions to simplify codes drm/amdgpu: Introduce new SETUP_TMR interface Revert "drm/amdgpu: workaround the TMR MC address issue (v2)" Qingqing Zhuo (2): drm/amd/display: Update modifier list for gfx10_3 Revert "Revert "drm/amdgpu: Ensure that the modifier requested is supported by plane."" Ramesh Errabolu (1): drm/amdgpu: Use iterator methods exposed by amdgpu_res_cursor.h in building SG_TABLE's for a VRAM BO Robin Singh (2): drm/amd/display: fixed divide by zero kernel crash during dsc enablement drm/amd/display: removed unused function dc_link_reallocate_mst_payload. Roman Li (1): drm/amd/display: Fix hangs with psr enabled on dcn3.xx Shashank Sharma (1): drm/amdgpu/dm: Fix NULL pointer crash during DP MST hotplug Shiwu Zhang (1): drm/ttm: fix error handling if no BO can be swapped out v4 Simon Ser (1): amd/display: allow non-linear multi-planar formats Thierry Reding (9): Merge branch 'drm/tegra/fixes' into drm/tegra/for-next gpu: host1x: Add early init and late exit callbacks drm/tegra: dc: Inherit DMA mask drm/tegra: dc: Parameterize maximum resolution drm/tegra: dc: Implement hardware cursor on Tegra186 and later drm/tegra: fb: Add diagnostics for framebuffer modifiers drm/tegra: gem: Add a clarifying comment drm/tegra: Count number of display controllers at runtime drm/tegra: Support sector layout on Tegra194 Tian Tao (1): drm/radeon/cik: remove set but not used variables Tvrtko Ursulin (1): drm/i915: Take request reference before arming the watchdog timer Ville Syrjälä (3): drm/i915: Restore lost glk FBC 16bpp w/a drm/i915: Restore lost glk ccs w/a drm/i915: Disable LTTPR detection on GLK once again Wesley Chalmers (2): drm/amd/display: Set LTTPR mode to non-LTTPR if no repeaters found drm/amd/display: Unconditionally clear training pattern set after lt Xiaojian Du (6): drm/amd/pm: update the driver interface header for vangogh drm/amd/pm: add support for new smu metrics table for vangogh drm/amd: update the atomfirmware header for smu12 drm/amd/pm: add the callback to get the bootup values for renoir drm/amd/pm: remove the "set" function of pp_dpm_mclk for vangogh drm/amd/pm: revise two names of sensor values for vangogh Yang Li (1): drm/radeon/si: Fix inconsistent indenting Zhenyu Wang (1): drm/i915/gvt: Remove duplicated register accessible check drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h | 4 - drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 63 +--- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 13 + drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 41 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 12 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 2 + drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 24 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 82 ++--- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 34 +- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 3 + drivers/gpu/drm/amd/amdgpu/gfx_v9_4.c | 16 +- drivers/gpu/drm/amd/amdgpu/gfx_v9_4_2.c | 32 +- drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c | 24 +- drivers/gpu/drm/amd/amdgpu/gfxhub_v2_0.c | 3 +- drivers/gpu/drm/amd/amdgpu/gfxhub_v2_1.c | 3 +- drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 3 +- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 9 +- drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 3 +- drivers/gpu/drm/amd/amdgpu/mmhub_v1_7.c | 24 +- drivers/gpu/drm/amd/amdgpu/mmhub_v2_0.c | 3 +- drivers/gpu/drm/amd/amdgpu/mmhub_v2_3.c | 3 +- drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c | 11 +- drivers/gpu/drm/amd/amdgpu/nbio_v6_1.c | 128 +++++++ drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c | 125 +++++++ drivers/gpu/drm/amd/amdgpu/nv.c | 10 +- drivers/gpu/drm/amd/amdgpu/psp_gfx_if.h | 11 +- drivers/gpu/drm/amd/amdgpu/sdma_v4_4.c | 35 +- drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 28 ++ drivers/gpu/drm/amd/amdgpu/soc15.c | 7 +- drivers/gpu/drm/amd/amdgpu/vi.c | 193 ++++++++++- drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c | 129 ++++++- drivers/gpu/drm/amd/amdkfd/kfd_process.c | 27 +- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 38 ++- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 3 +- .../drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 35 ++ .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_hdcp.c | 8 +- .../drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 25 ++ .../amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 9 +- .../drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c | 58 +++- .../amd/display/dc/clk_mgr/dcn30/dcn30_clk_mgr.c | 4 +- drivers/gpu/drm/amd/display/dc/core/dc.c | 37 +- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 87 ++--- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 63 +++- drivers/gpu/drm/amd/display/dc/core/dc_link_hwss.c | 4 +- drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 33 +- drivers/gpu/drm/amd/display/dc/dc.h | 13 +- drivers/gpu/drm/amd/display/dc/dc_link.h | 1 - drivers/gpu/drm/amd/display/dc/dc_stream.h | 1 - drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c | 2 + .../amd/display/dc/dce110/dce110_hw_sequencer.c | 10 +- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hubp.c | 15 +- .../gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 7 +- drivers/gpu/drm/amd/display/dc/dcn21/dcn21_hwseq.c | 2 + .../gpu/drm/amd/display/dc/dcn301/dcn301_init.c | 2 + drivers/gpu/drm/amd/display/dc/dm_helpers.h | 2 + drivers/gpu/drm/amd/display/dc/inc/dc_link_dp.h | 8 + drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 31 +- .../drm/amd/display/modules/hdcp/hdcp1_execution.c | 2 - .../drm/amd/display/modules/hdcp/hdcp2_execution.c | 2 - .../gpu/drm/amd/display/modules/hdcp/hdcp_psp.c | 2 + .../drm/amd/include/asic_reg/gc/gc_9_4_1_sh_mask.h | 16 + drivers/gpu/drm/amd/include/atomfirmware.h | 41 +++ drivers/gpu/drm/amd/pm/amdgpu_pm.c | 4 +- .../gpu/drm/amd/pm/inc/smu11_driver_if_vangogh.h | 40 ++- drivers/gpu/drm/amd/pm/inc/smu_v11_0.h | 2 +- drivers/gpu/drm/amd/pm/inc/smu_v12_0.h | 2 + drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 1 + drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 378 +++++++++++++++++++-- drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c | 1 + drivers/gpu/drm/amd/pm/swsmu/smu12/smu_v12_0.c | 123 +++++++ drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 55 ++- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 2 - drivers/gpu/drm/i915/display/intel_display.c | 3 +- .../gpu/drm/i915/display/intel_dp_link_training.c | 2 +- drivers/gpu/drm/i915/display/intel_fbc.c | 2 +- drivers/gpu/drm/i915/display/intel_overlay.c | 4 +- drivers/gpu/drm/i915/display/intel_psr.c | 3 +- drivers/gpu/drm/i915/gem/i915_gem_shrinker.c | 1 + drivers/gpu/drm/i915/gvt/cmd_parser.c | 5 - drivers/gpu/drm/i915/gvt/gtt.c | 6 - drivers/gpu/drm/i915/gvt/gvt.c | 8 +- drivers/gpu/drm/i915/i915_request.c | 3 +- drivers/gpu/drm/radeon/cik.c | 4 - drivers/gpu/drm/radeon/si.c | 2 +- drivers/gpu/drm/tegra/dc.c | 113 +++++- drivers/gpu/drm/tegra/dc.h | 6 + drivers/gpu/drm/tegra/drm.c | 27 +- drivers/gpu/drm/tegra/drm.h | 5 + drivers/gpu/drm/tegra/fb.c | 10 + drivers/gpu/drm/tegra/gem.h | 6 + drivers/gpu/drm/tegra/gr2d.c | 4 +- drivers/gpu/drm/tegra/gr3d.c | 4 +- drivers/gpu/drm/tegra/hub.c | 41 ++- drivers/gpu/drm/tegra/plane.c | 32 ++ drivers/gpu/drm/tegra/vic.c | 4 +- drivers/gpu/drm/ttm/ttm_device.c | 2 +- drivers/gpu/drm/ttm/ttm_tt.c | 2 + drivers/gpu/drm/vmwgfx/ttm_memory.c | 2 +- drivers/gpu/host1x/bus.c | 31 ++ drivers/gpu/host1x/cdma.c | 11 +- drivers/gpu/host1x/debug.c | 14 +- drivers/gpu/host1x/dev.c | 6 + drivers/gpu/host1x/dev.h | 13 +- drivers/gpu/host1x/hw/cdma_hw.c | 2 +- drivers/gpu/host1x/hw/channel_hw.c | 10 +- drivers/gpu/host1x/hw/debug_hw.c | 2 +- drivers/gpu/host1x/hw/hw_host1x07_vm.h | 2 +- drivers/gpu/host1x/intr.c | 28 +- drivers/gpu/host1x/intr.h | 4 +- drivers/gpu/host1x/job.c | 5 +- drivers/gpu/host1x/syncpt.c | 202 ++++++----- drivers/gpu/host1x/syncpt.h | 4 +- drivers/staging/media/tegra-video/vi.c | 6 +- drivers/video/fbdev/efifb.c | 6 +- include/linux/host1x.h | 18 +- 121 files changed, 2337 insertions(+), 621 deletions(-)

2 1

[PATCH] drm: log errors in drm_gem_fb_init_with_funcs
by Simon Ser 30 Apr '21

30 Apr '21

Let the user know what went wrong in drm_gem_fb_init_with_funcs failure paths. Signed-off-by: Simon Ser <contact(a)emersion.fr> Cc: Daniel Vetter <daniel.vetter(a)ffwll.ch> Cc: Sam Ravnborg <sam(a)ravnborg.org> Cc: Noralf Trønnes <noralf(a)tronnes.org> Cc: Andrzej Pietrasiewicz <andrzej.p(a)collabora.com> --- drivers/gpu/drm/drm_gem_framebuffer_helper.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_gem_framebuffer_helper.c b/drivers/gpu/drm/drm_gem_framebuffer_helper.c index 109d11fb4cd4..e4a3c7eb43b2 100644 --- a/drivers/gpu/drm/drm_gem_framebuffer_helper.c +++ b/drivers/gpu/drm/drm_gem_framebuffer_helper.c @@ -155,8 +155,10 @@ int drm_gem_fb_init_with_funcs(struct drm_device *dev, int ret, i; info = drm_get_format_info(dev, mode_cmd); - if (!info) + if (!info) { + drm_dbg_kms(dev, "Failed to get FB format info\n"); return -EINVAL; + } for (i = 0; i < info->num_planes; i++) { unsigned int width = mode_cmd->width / (i ? info->hsub : 1); @@ -175,6 +177,9 @@ int drm_gem_fb_init_with_funcs(struct drm_device *dev, + mode_cmd->offsets[i]; if (objs[i]->size < min_size) { + drm_dbg_kms(dev, + "GEM object size (%u) smaller than minimum size (%u) for plane %d\n", + objs[i]->size, min_size, i); drm_gem_object_put(objs[i]); ret = -EINVAL; goto err_gem_object_put; -- 2.31.1

4 3

[PATCH] drm/i915: Be more gentle with exiting non-persistent context
by Tvrtko Ursulin 30 Apr '21

30 Apr '21

From: Tvrtko Ursulin <tvrtko.ursulin(a)intel.com> When a non-persistent context exits we currently mark it as banned in order to trigger fast termination of any outstanding GPU jobs it may have left running. In doing so we apply a very strict 1ms limit in which the left over job has to preempt before we issues an engine resets. Some workloads are not able to cleanly preempt in that time window and it can be argued that it would instead be better to give them a bit more grace since avoiding engine resets is generally preferrable. To achieve this the patch splits handling of banned contexts from simply exited non-persistent ones and then applies different timeouts for both and also extends the criteria which determines if a request should be scheduled back in after preemption or not. 15ms preempt timeout grace is given to exited non-persistent contexts which have been empirically tested to satisfy customers requirements and still provides reasonably quick cleanup post exit. Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin(a)intel.com> Cc: Chris Wilson <chris(a)chris-wilson.co.uk> Cc: Zhen Han <zhen.han(a)intel.com> --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 15 +++++++++------ drivers/gpu/drm/i915/gt/intel_context.h | 17 +++++++++++++++++ drivers/gpu/drm/i915/gt/intel_context_types.h | 1 + .../drm/i915/gt/intel_execlists_submission.c | 12 ++++++++++-- drivers/gpu/drm/i915/i915_request.c | 2 +- 5 files changed, 38 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c index fd8ee52e17a4..5a6eba1232cd 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c @@ -426,7 +426,8 @@ static struct intel_engine_cs *active_engine(struct intel_context *ce) return engine; } -static void kill_engines(struct i915_gem_engines *engines, bool ban) +static void +kill_engines(struct i915_gem_engines *engines, bool ban, bool persistent) { struct i915_gem_engines_iter it; struct intel_context *ce; @@ -443,6 +444,8 @@ static void kill_engines(struct i915_gem_engines *engines, bool ban) if (ban && intel_context_set_banned(ce)) continue; + else if (!persistent && intel_context_set_non_persistent(ce)) + continue; /* * Check the current active state of this context; if we @@ -454,7 +457,7 @@ static void kill_engines(struct i915_gem_engines *engines, bool ban) engine = active_engine(ce); /* First attempt to gracefully cancel the context */ - if (engine && !__cancel_engine(engine) && ban) + if (engine && !__cancel_engine(engine) && (ban || !persistent)) /* * If we are unable to send a preemptive pulse to bump * the context from the GPU, we have to resort to a full @@ -466,8 +469,6 @@ static void kill_engines(struct i915_gem_engines *engines, bool ban) static void kill_context(struct i915_gem_context *ctx) { - bool ban = (!i915_gem_context_is_persistent(ctx) || - !ctx->i915->params.enable_hangcheck); struct i915_gem_engines *pos, *next; spin_lock_irq(&ctx->stale.lock); @@ -480,7 +481,8 @@ static void kill_context(struct i915_gem_context *ctx) spin_unlock_irq(&ctx->stale.lock); - kill_engines(pos, ban); + kill_engines(pos, !ctx->i915->params.enable_hangcheck, + i915_gem_context_is_persistent(ctx)); spin_lock_irq(&ctx->stale.lock); GEM_BUG_ON(i915_sw_fence_signaled(&pos->fence)); @@ -526,7 +528,8 @@ static void engines_idle_release(struct i915_gem_context *ctx, kill: if (list_empty(&engines->link)) /* raced, already closed */ - kill_engines(engines, true); + kill_engines(engines, true, + i915_gem_context_is_persistent(ctx)); i915_sw_fence_commit(&engines->fence); } diff --git a/drivers/gpu/drm/i915/gt/intel_context.h b/drivers/gpu/drm/i915/gt/intel_context.h index f83a73a2b39f..b0e812b8ce39 100644 --- a/drivers/gpu/drm/i915/gt/intel_context.h +++ b/drivers/gpu/drm/i915/gt/intel_context.h @@ -220,6 +220,23 @@ static inline bool intel_context_set_banned(struct intel_context *ce) return test_and_set_bit(CONTEXT_BANNED, &ce->flags); } +static inline bool intel_context_is_non_persistent(const struct intel_context *ce) +{ + return test_bit(CONTEXT_NON_PERSISTENT, &ce->flags); +} + +static inline bool intel_context_set_non_persistent(struct intel_context *ce) +{ + return test_and_set_bit(CONTEXT_NON_PERSISTENT, &ce->flags); +} + +static inline bool intel_context_is_schedulable(const struct intel_context *ce) +{ + return !intel_context_is_banned(ce) && + !(intel_context_is_closed(ce) && + intel_context_is_non_persistent(ce)); +} + static inline bool intel_context_force_single_submission(const struct intel_context *ce) { diff --git a/drivers/gpu/drm/i915/gt/intel_context_types.h b/drivers/gpu/drm/i915/gt/intel_context_types.h index ed8c447a7346..aa949c539e93 100644 --- a/drivers/gpu/drm/i915/gt/intel_context_types.h +++ b/drivers/gpu/drm/i915/gt/intel_context_types.h @@ -95,6 +95,7 @@ struct intel_context { #define CONTEXT_BANNED 6 #define CONTEXT_FORCE_SINGLE_SUBMISSION 7 #define CONTEXT_NOPREEMPT 8 +#define CONTEXT_NON_PERSISTENT 9 /* Only if also closed. */ struct { u64 timeout_us; diff --git a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c index de124870af44..5ad7272fbbc4 100644 --- a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c +++ b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c @@ -478,7 +478,7 @@ __execlists_schedule_in(struct i915_request *rq) !intel_engine_has_heartbeat(engine))) intel_context_set_banned(ce); - if (unlikely(intel_context_is_banned(ce) || bad_request(rq))) + if (unlikely(!intel_context_is_schedulable(ce) || bad_request(rq))) reset_active(rq, engine); if (IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM)) @@ -1204,12 +1204,20 @@ static void record_preemption(struct intel_engine_execlists *execlists) static unsigned long active_preempt_timeout(struct intel_engine_cs *engine, const struct i915_request *rq) { + struct intel_context *ce; + if (!rq) return 0; + ce = rq->context; + /* Force a fast reset for terminated contexts (ignoring sysfs!) */ - if (unlikely(intel_context_is_banned(rq->context) || bad_request(rq))) + if (unlikely(intel_context_is_banned(ce) || bad_request(rq))) return 1; + /* Longer grace for closed non-persistent contexts to avoid resets. */ + else if (unlikely(intel_context_is_closed(ce) && + intel_context_is_non_persistent(ce))) + return 15; return READ_ONCE(engine->props.preempt_timeout_ms); } diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c index bec9c3652188..bbac87535923 100644 --- a/drivers/gpu/drm/i915/i915_request.c +++ b/drivers/gpu/drm/i915/i915_request.c @@ -660,7 +660,7 @@ bool __i915_request_submit(struct i915_request *request) goto active; } - if (unlikely(intel_context_is_banned(request->context))) + if (unlikely(!intel_context_is_schedulable(request->context))) i915_request_set_error_once(request, -EIO); if (unlikely(fatal_error(request->fence.error))) -- 2.30.2

2 4

[PATCH 1/2] drm/i915/overlay: Fix active retire callback alignment
by Tvrtko Ursulin 30 Apr '21

30 Apr '21

From: Tvrtko Ursulin <tvrtko.ursulin(a)intel.com> __i915_active_call annotation is required on the retire callback to ensure correct function alignment. Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin(a)intel.com> Fixes: a21ce8ad12d2 ("drm/i915/overlay: Switch to using i915_active tracking") Cc: Chris Wilson <chris(a)chris-wilson.co.uk> Cc: Matthew Auld <matthew.auld(a)intel.com> --- drivers/gpu/drm/i915/display/intel_overlay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_overlay.c b/drivers/gpu/drm/i915/display/intel_overlay.c index fffbde4256db..428819ba18dd 100644 --- a/drivers/gpu/drm/i915/display/intel_overlay.c +++ b/drivers/gpu/drm/i915/display/intel_overlay.c @@ -383,7 +383,7 @@ static void intel_overlay_off_tail(struct intel_overlay *overlay) i830_overlay_clock_gating(dev_priv, true); } -static void +__i915_active_call static void intel_overlay_last_flip_retire(struct i915_active *active) { struct intel_overlay *overlay = -- 2.30.2

3 6

[PATCH v3 0/3] drm/bridge: nwl-dsi: Get MIPI DSI controller and PHY ready in ->mode_set()
by Liu Ying 30 Apr '21

30 Apr '21

Hi, This series aims to make the nwl-dsi bridge be able to connect with more MIPI DSI panels. Some MIPI DSI panel drivers like 'raydium,rm68200' send MIPI_DCS_SET_DISPLAY_ON commands in panel_funcs->prepare(), which requires the MIPI DSI controller and PHY to be ready beforehand. However, the existing nwl-dsi driver gets the MIPI DSI controller and PHY ready in bridge_funcs->pre_enable(), which happens after the panel_funcs->prepare(). So, this series shifts the bridge operation ealier from bridge_funcs->pre_enable() to bridge_funcs->mode_set(). Patch 3/3 does the essential bridge operation shift. Patch 1/3 and 2/3 are split from the original single patch in v2 and are needed by patch 3/3. This split-up helps clarify changes better. The split-up is done in this way: 1) Patch 1/3 forces a full modeset when crtc_state->active is changed to be true(which implies only connector's DPMS is brought out of "Off" status, though not necessarily). This makes sure ->mode_set() and ->atomic_disable() will be called in pairs. 2) Patch 2/3 removes a check on unchanged HS clock rate from ->mode_set(), to make sure MIPI DSI controller and PHY are brought up and taken down in pairs. 3) Patch 3/3 shifts the bridge operation as the last step. v2->v3: * Split the single patch in v2 into 3 patches. (Neil) v1->v2: * Fix a typo in commit message - s/unchange/unchanged/ Liu Ying (3): drm/bridge: nwl-dsi: Force a full modeset when crtc_state->active is changed to be true drm/bridge: nwl-dsi: Remove a check on unchanged HS clock rate from ->mode_set() drm/bridge: nwl-dsi: Get MIPI DSI controller and PHY ready in ->mode_set() drivers/gpu/drm/bridge/nwl-dsi.c | 86 +++++++++++++++++--------------- 1 file changed, 46 insertions(+), 40 deletions(-) -- 2.25.1

4 12

[PATCH] SPI: meson-spifc add missed calls to remove function
by Artem Lapkin 30 Apr '21

30 Apr '21

Problem: rmmod meson_gx_mmc - not stable without spi_master_suspend call and we can get stuck when try unload this module rmmod meson_gx_mmc ... [ 421.108614] Deleting MTD partitions on "spi0.0": [ 424.219862] spi_master spi0: Failed to power device: -13 ... lsmod | grep spi spi_meson_spifc 16384 -1 Solution: just add spi_master_suspend(master) call Signed-off-by: Artem Lapkin <art(a)khadas.com> --- drivers/spi/spi-meson-spifc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-meson-spifc.c b/drivers/spi/spi-meson-spifc.c index 8eca6f24c..8a97a6dbf 100644 --- a/drivers/spi/spi-meson-spifc.c +++ b/drivers/spi/spi-meson-spifc.c @@ -359,6 +359,7 @@ static int meson_spifc_remove(struct platform_device *pdev) struct spi_master *master = platform_get_drvdata(pdev); struct meson_spifc *spifc = spi_master_get_devdata(master); + spi_master_suspend(master); pm_runtime_get_sync(&pdev->dev); clk_disable_unprepare(spifc->clk); pm_runtime_disable(&pdev->dev); -- 2.25.1

3 6

[PATCH v5 0/9] drm: Support simple-framebuffer devices and firmware fbs
by Thomas Zimmermann 30 Apr '21

30 Apr '21

This patchset adds support for simple-framebuffer platform devices and a handover mechanism for native drivers to take-over control of the hardware. The new driver, called simpledrm, binds to a simple-framebuffer platform device. The kernel's boot code creates such devices for firmware-provided framebuffers, such as EFI-GOP or VESA. Typically the BIOS, UEFI or boot loader sets up the framebuffers. Description via device tree is also an option. Simpledrm is small enough to be linked into the kernel. The driver's main purpose is to provide graphical output during the early phases of the boot process, before the native DRM drivers are available. Native drivers are typically loaded from an initrd ram disk. Occationally simpledrm can also serve as interim solution on graphics hardware without native DRM driver. So far distributions rely on fbdev drivers, such as efifb, vesafb or simplefb, for early-boot graphical output. However fbdev is deprecated and the drivers do not provide DRM interfaces for modern userspace. Patches 1 and 2 prepare the DRM format helpers for simpledrm. Patches 4 to 8 add the simpledrm driver. It's build on simple DRM helpers and SHMEM. It supports 16-bit, 24-bit and 32-bit RGB framebuffers. During pageflips, SHMEM buffers are copied into the framebuffer memory, similar to cirrus or mgag200. The code in patches 7 and 8 handles clocks and regulators. It's based on the simplefb drivers, but has been modified for DRM. These patches will be squashed into one for the merger, so that the result is bisectable. Patches 3 and 9 add a hand-over mechanism. Simpledrm acquires it's framebuffer's I/O-memory range and can be hot-unplugged by a native driver. The native driver will remove simpledrm before taking over the hardware. The removal is integrated into existing helpers, so existing drivers use it automatically. I've also been working on fastboot support (i.e., flicker-free booting). This requires state-readout from simpledrm via generic interfaces, as outlined in [1]. I do have some prototype code, but it will take a while to get this ready. Simpledrm will then support it. I've tested simpledrm with x86 EFI and VESA framebuffers, which both work reliably. The fbdev console and Weston work automatically. Xorg requires manual configuration of the device. Xorgs current modesetting driver does not work with both, platform and PCI device, for the same physical hardware. Once configured, X11 works. I looked into X11, but couldn't see an easy way of fixing the problem. With the push towards Wayland+Xwayland I expect the problem to become a non-issue soon. Additional testing has been reported at [2]. One cosmetical issue is that simpledrm's device file is card0 and the native driver's device file is card1. After simpledrm has been kicked out, only card1 is left. This does not seem to be a practical problem however. TODO/IDEAS: * provide deferred takeover * provide bootsplash DRM client * make simplekms usable with ARM-EFI fbs v5: * fix build error introduced by rebasing v4 * fix typo in documenation v4: * provide interface for acquiring firmware framebuffers (Daniel) * make simpledrm and simplefb mutually exclusive (Maxime) * documentation fixes v3: * clear screen to black when disabled (Daniel) * rebase onto existing aperture helpers * detach via hot-unplug via platform_device_unregister() v2: * rename to simpledrm, aperture helpers * reorganized patches * use hotplug helpers for removal (Daniel) * added DT match tables (Rob) * use shadow-plane helpers * lots of minor cleanups [1] https://lore.kernel.org/dri-devel/CAKMK7uHtqHy_oz4W7F+hmp9iqp7W5Ra8CxPvJ=9B… [2] https://lore.kernel.org/dri-devel/1761762.3HQLrFs1K7@nerdopolis/ Thomas Zimmermann (9): drm/format-helper: Pass destination pitch to drm_fb_memcpy_dstclip() drm/format-helper: Add blitter functions drm/aperture: Add infrastructure for aperture ownership drm: Add simpledrm driver drm/simpledrm: Add fbdev emulation drm/simpledrm: Initialize framebuffer data from device-tree node drm/simpledrm: Acquire clocks from DT device node drm/simpledrm: Acquire regulators from DT device node drm/simpledrm: Acquire memory aperture for framebuffer MAINTAINERS | 7 + drivers/gpu/drm/drm_aperture.c | 221 +++++- drivers/gpu/drm/drm_format_helper.c | 96 ++- drivers/gpu/drm/mgag200/mgag200_mode.c | 2 +- drivers/gpu/drm/tiny/Kconfig | 16 + drivers/gpu/drm/tiny/Makefile | 1 + drivers/gpu/drm/tiny/cirrus.c | 2 +- drivers/gpu/drm/tiny/simpledrm.c | 896 +++++++++++++++++++++++++ drivers/video/fbdev/Kconfig | 2 +- include/drm/drm_aperture.h | 4 + include/drm/drm_format_helper.h | 10 +- 11 files changed, 1245 insertions(+), 12 deletions(-) create mode 100644 drivers/gpu/drm/tiny/simpledrm.c base-commit: bf25e1addaf44137e20ce95de72ff118b37d808c prerequisite-patch-id: c2b2f08f0eccc9f5df0c0da49fa1d36267deb11d prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24 prerequisite-patch-id: c59ca2ddb182af06006fa360ad3e90fe16b93d3a prerequisite-patch-id: dd15fb5fe2130e0dbf2fb7df6cae76d808ef6816 prerequisite-patch-id: 90618028e0df10398d6a0e4ae261e1e855905d38 prerequisite-patch-id: 3ee4d936e76da021ac3ea2dea586582813263876 prerequisite-patch-id: 8f302cdd86509f93ae2f573718264a7fb332c098 prerequisite-patch-id: b4b1d4a05a1db29696b3aea8572ff982677ec4b5 prerequisite-patch-id: 2a9db4556e8ecf0f2f2caa23ee288579d00ae002 -- 2.31.1

1 9

← Newer
1
...
18
19
20
21
22
23
24
...
72
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel April 2021