dri-devel April 2021

dri-devel@lists.freedesktop.org

317 participants
715 discussions

[PATCH] drm/mgag200: Remove redundant assignment to status and clock
by Jiapeng Chong 30 Apr '21

30 Apr '21

Variable status is set to zero but this value is never read as it is overwritten with a new value later on,clock is being assigned a value from a calculation however the variable is never read,hence these are redundant assignments that can be removed. Clean up the following clang-analyzer warning: drivers/gpu/drm/mgag200/mgag200_mode.c:284:3: warning: Value stored to 'clock' is never read [clang-analyzer-deadcode.DeadStores]. drivers/gpu/drm/mgag200/mgag200_mode.c:98:2: warning: Value stored to 'status' is never read [clang-analyzer-deadcode.DeadStores]. Reported-by: Abaci Robot <abaci(a)linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong(a)linux.alibaba.com> --- drivers/gpu/drm/mgag200/mgag200_mode.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c index cece3e5..c4d5be8 100644 --- a/drivers/gpu/drm/mgag200/mgag200_mode.c +++ b/drivers/gpu/drm/mgag200/mgag200_mode.c @@ -95,7 +95,6 @@ static inline void mga_wait_vsync(struct mga_device *mdev) status = RREG32(MGAREG_Status); } while ((status & 0x08) && time_before(jiffies, timeout)); timeout = jiffies + HZ/10; - status = 0; do { status = RREG32(MGAREG_Status); } while (!(status & 0x08) && time_before(jiffies, timeout)); @@ -280,8 +279,6 @@ static int mga_g200se_set_plls(struct mga_device *mdev, long clock) p |= (fvv << 4); m |= 0x80; - - clock = clock / 2; } if (delta > permitteddelta) { -- 1.8.3.1

1 0

[PULL] drm-intel-next-fixes for the merge window #2
by Jani Nikula 30 Apr '21

30 Apr '21

Hi Dave & Daniel - One more fix for -rc1. drm-intel-next-fixes-2021-04-30: drm/i915 GVT fixes for v5.13-rc1: - Fix a possible division by zero in vgpu display rate calculation BR, Jani. The following changes since commit 270e3cc5aa382f63ea20b93c3d20162a891dc638: drm/i915: Fix docbook descriptions for i915_gem_shrinker (2021-04-26 11:54:33 +0300) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-next-fixes-2021-04-30 for you to fetch changes up to c7b397e9ca4d6828e3e3f504c80bcb1fe535c348: Merge tag 'gvt-next-fixes-2021-04-29' of https://github.com/intel/gvt-linux into drm-intel-next-fixes (2021-04-29 13:15:51 +0300) ---------------------------------------------------------------- drm/i915 GVT fixes for v5.13-rc1: - Fix a possible division by zero in vgpu display rate calculation ---------------------------------------------------------------- Colin Xu (1): drm/i915/gvt: Prevent divided by zero when calculating refresh rate Jani Nikula (1): Merge tag 'gvt-next-fixes-2021-04-29' of https://github.com/intel/gvt-linux into drm-intel-next-fixes drivers/gpu/drm/i915/gvt/handlers.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- Jani Nikula, Intel Open Source Graphics Center

1 0

[PATCH V2 1/2] dt-bindings: drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 bindings
by Marek Vasut 30 Apr '21

30 Apr '21

Add DT binding document for TI SN65DSI83 and SN65DSI84 DSI to LVDS bridge. Signed-off-by: Marek Vasut <marex(a)denx.de> Cc: Douglas Anderson <dianders(a)chromium.org> Cc: Jagan Teki <jagan(a)amarulasolutions.com> Cc: Laurent Pinchart <laurent.pinchart(a)ideasonboard.com> Cc: Linus Walleij <linus.walleij(a)linaro.org> Cc: Rob Herring <robh+dt(a)kernel.org> Cc: Sam Ravnborg <sam(a)ravnborg.org> Cc: Stephen Boyd <swboyd(a)chromium.org> Cc: devicetree(a)vger.kernel.org To: dri-devel(a)lists.freedesktop.org --- V2: Add compatible string for SN65DSI84, since this is now tested on it --- .../bindings/display/bridge/ti,sn65dsi83.yaml | 134 ++++++++++++++++++ 1 file changed, 134 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml new file mode 100644 index 000000000000..42d11b46a1eb --- /dev/null +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml @@ -0,0 +1,134 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/bridge/ti,sn65dsi83.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: SN65DSI83 and SN65DSI84 DSI to LVDS bridge chip + +maintainers: + - Marek Vasut <marex(a)denx.de> + +description: | + Texas Instruments SN65DSI83 1x Single-link MIPI DSI + to 1x Single-link LVDS + https://www.ti.com/lit/gpn/sn65dsi83 + Texas Instruments SN65DSI84 1x Single-link MIPI DSI + to 1x Dual-link or 2x Single-link LVDS + https://www.ti.com/lit/gpn/sn65dsi84 + +properties: + compatible: + oneOf: + - const: ti,sn65dsi83 + - const: ti,sn65dsi84 + + reg: + const: 0x2d + + enable-gpios: + maxItems: 1 + description: GPIO specifier for bridge_en pin (active high). + + ports: + type: object + additionalProperties: false + + properties: + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + + port@0: + type: object + additionalProperties: false + + description: + Video port for MIPI DSI input + + properties: + reg: + const: 0 + + endpoint: + type: object + additionalProperties: false + properties: + remote-endpoint: true + data-lanes: + description: array of physical DSI data lane indexes. + + required: + - reg + + port@1: + type: object + additionalProperties: false + + description: + Video port for LVDS output (panel or bridge). + + properties: + reg: + const: 1 + + endpoint: + type: object + additionalProperties: false + properties: + remote-endpoint: true + + required: + - reg + + required: + - "#address-cells" + - "#size-cells" + - port@0 + - port@1 + +required: + - compatible + - reg + - enable-gpios + - ports + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + bridge@2d { + compatible = "ti,sn65dsi83"; + reg = <0x2d>; + + enable-gpios = <&gpio2 1 GPIO_ACTIVE_HIGH>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + endpoint { + remote-endpoint = <&dsi0_out>; + data-lanes = <1 2 3 4>; + }; + }; + + port@1 { + reg = <1>; + endpoint { + remote-endpoint = <&panel_in_lvds>; + }; + }; + }; + }; + }; -- 2.30.2

6 18

[PATCH v10 0/1] drm/drm_mst: Use Extended Base Receiver Capability
by Nikola Cornij 29 Apr '21

29 Apr '21

Change history: v10: - Removed mistakenly added temporary file v9: - Actually send the changes under v8 below (missed to commit before sending v8) v8: - Chaged link lanes and rate parameters to u8 v7: - Fixed formatting - Fixed 'unused variable' compile warning - Fixed comment format v6: - Submited from (hopefully) the correct repo to fix build error v5: - Fixed min_t() macro arguments v4: - Fixed drm/radeon/ lane count and rate v3: - Fixed check-patch errors v2: - No changes, this was my mistaken reply to my patch v1: - Initial revision Nikola Cornij (1): drm/drm_mst: Use Extended Base Receiver Capability DPCD space .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 5 +++ .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 18 ++++++++++ drivers/gpu/drm/amd/display/dc/dc_link.h | 2 ++ drivers/gpu/drm/drm_dp_mst_topology.c | 33 ++++++++++++------- drivers/gpu/drm/i915/display/intel_dp_mst.c | 6 +++- drivers/gpu/drm/nouveau/dispnv50/disp.c | 3 +- drivers/gpu/drm/radeon/radeon_dp_mst.c | 7 ++++ include/drm/drm_dp_mst_helper.h | 12 ++++++- 8 files changed, 71 insertions(+), 15 deletions(-) -- 2.25.1

1 1

[PATCH v9 0/1] drm/drm_mst: Use Extended Base Receiver Capability
by Nikola Cornij 29 Apr '21

29 Apr '21

Change history: v9: - Actually send the changes under v8 below (missed to commit before sending v8) v8: - Chaged link lanes and rate parameters to u8 v7: - Fixed formatting - Fixed 'unused variable' compile warning - Fixed comment format v6: - Submited from (hopefully) the correct repo to fix build error v5: - Fixed min_t() macro arguments v4: - Fixed drm/radeon/ lane count and rate v3: - Fixed check-patch errors v2: - No changes, this was my mistaken reply to my patch v1: - Initial revision Nikola Cornij (1): drm/drm_mst: Use Extended Base Receiver Capability DPCD space .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 5 +++ .../gpu/drm/amd/display/dc/core/dc_link_dp.c | 18 ++++++++++ drivers/gpu/drm/amd/display/dc/dc_link.h | 2 ++ drivers/gpu/drm/drm_dp_mst_topology.c | 33 ++++++++++++------- drivers/gpu/drm/i915/display/intel_dp_mst.c | 6 +++- drivers/gpu/drm/nouveau/dispnv50/disp.c | 3 +- drivers/gpu/drm/radeon/radeon_dp_mst.c | 7 ++++ f.txt | 6 ++++ include/drm/drm_dp_mst_helper.h | 12 ++++++- 9 files changed, 77 insertions(+), 15 deletions(-) create mode 100644 f.txt -- 2.25.1

1 1

[PATCH] drm/radeon/dpm: Disable sclk switching when two 4K 60Hz monitors are connected
by Kai-Heng Feng 29 Apr '21

29 Apr '21

Screen flickers rapidly when two 4K 60Hz monitors are connected to an Oland card. This issue doesn't happen when one monitor is 4K 60Hz (pixelclock 594MHz) and another one is 4K 30Hz (pixelclock 297MHz). The issue is gone after setting "power_dpm_force_performance_level" to "high". Following the lead, we found that the issue only occurs when sclk is too low. So resolve the issue by disabling sclk switching when there are two monitors that requires high pixelclock (> 297MHz). Signed-off-by: Kai-Heng Feng <kai.heng.feng(a)canonical.com> --- drivers/gpu/drm/radeon/radeon.h | 1 + drivers/gpu/drm/radeon/radeon_pm.c | 8 ++++++++ drivers/gpu/drm/radeon/si_dpm.c | 3 +++ 3 files changed, 12 insertions(+) diff --git a/drivers/gpu/drm/radeon/radeon.h b/drivers/gpu/drm/radeon/radeon.h index 42281fce552e6..56ed5634cebef 100644 --- a/drivers/gpu/drm/radeon/radeon.h +++ b/drivers/gpu/drm/radeon/radeon.h @@ -1549,6 +1549,7 @@ struct radeon_dpm { void *priv; u32 new_active_crtcs; int new_active_crtc_count; + int high_pixelclock_count; u32 current_active_crtcs; int current_active_crtc_count; bool single_display; diff --git a/drivers/gpu/drm/radeon/radeon_pm.c b/drivers/gpu/drm/radeon/radeon_pm.c index 0c1950f4e146f..3861c0b98fcf3 100644 --- a/drivers/gpu/drm/radeon/radeon_pm.c +++ b/drivers/gpu/drm/radeon/radeon_pm.c @@ -1767,6 +1767,7 @@ static void radeon_pm_compute_clocks_dpm(struct radeon_device *rdev) struct drm_device *ddev = rdev->ddev; struct drm_crtc *crtc; struct radeon_crtc *radeon_crtc; + struct radeon_connector *radeon_connector; if (!rdev->pm.dpm_enabled) return; @@ -1776,6 +1777,7 @@ static void radeon_pm_compute_clocks_dpm(struct radeon_device *rdev) /* update active crtc counts */ rdev->pm.dpm.new_active_crtcs = 0; rdev->pm.dpm.new_active_crtc_count = 0; + rdev->pm.dpm.high_pixelclock_count = 0; if (rdev->num_crtc && rdev->mode_info.mode_config_initialized) { list_for_each_entry(crtc, &ddev->mode_config.crtc_list, head) { @@ -1783,6 +1785,12 @@ static void radeon_pm_compute_clocks_dpm(struct radeon_device *rdev) if (crtc->enabled) { rdev->pm.dpm.new_active_crtcs |= (1 << radeon_crtc->crtc_id); rdev->pm.dpm.new_active_crtc_count++; + if (!radeon_crtc->connector) + continue; + + radeon_connector = to_radeon_connector(radeon_crtc->connector); + if (radeon_connector->pixelclock_for_modeset > 297000) + rdev->pm.dpm.high_pixelclock_count++; } } } diff --git a/drivers/gpu/drm/radeon/si_dpm.c b/drivers/gpu/drm/radeon/si_dpm.c index 9186095518047..be6fa3257d1bc 100644 --- a/drivers/gpu/drm/radeon/si_dpm.c +++ b/drivers/gpu/drm/radeon/si_dpm.c @@ -2995,6 +2995,9 @@ static void si_apply_state_adjust_rules(struct radeon_device *rdev, ni_dpm_vblank_too_short(rdev)) disable_mclk_switching = true; + if (rdev->pm.dpm.high_pixelclock_count > 1) + disable_sclk_switching = true; + if (rps->vclk || rps->dclk) { disable_mclk_switching = true; disable_sclk_switching = true; -- 2.30.2

2 1

Re: [PATCH 000/190] Revertion of all of the umn.edu commits
by Daniel Vetter 29 Apr '21

29 Apr '21

On Wed, Apr 21, 2021 at 3:01 PM Greg Kroah-Hartman <gregkh(a)linuxfoundation.org> wrote: > > I have been meaning to do this for a while, but recent events have > finally forced me to do so. > > Commits from @umn.edu addresses have been found to be submitted in "bad > faith" to try to test the kernel community's ability to review "known > malicious" changes. The result of these submissions can be found in a > paper published at the 42nd IEEE Symposium on Security and Privacy > entitled, "Open Source Insecurity: Stealthily Introducing > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > of Minnesota) and Kangjie Lu (University of Minnesota). > > Because of this, all submissions from this group must be reverted from > the kernel tree and will need to be re-reviewed again to determine if > they actually are a valid fix. Until that work is complete, remove this > change to ensure that no problems are being introduced into the > codebase. > > This patchset has the "easy" reverts, there are 68 remaining ones that > need to be manually reviewed. Some of them are not able to be reverted > as they already have been reverted, or fixed up with follow-on patches > as they were determined to be invalid. Proof that these submissions > were almost universally wrong. Will you take care of these remaining ones in subsequent patches too? > I will be working with some other kernel developers to determine if any > of these reverts were actually valid changes, were actually valid, and > if so, will resubmit them properly later. For now, it's better to be > safe. > > I'll take this through my tree, so no need for any maintainer to worry > about this, but they should be aware that future submissions from anyone > with a umn.edu address should be by default-rejected unless otherwise > determined to actually be a valid fix (i.e. they provide proof and you > can verify it, but really, why waste your time doing that extra work?) > > thanks, > > greg k-h > > Greg Kroah-Hartman (190): > Revert "net/rds: Avoid potential use after free in > rds_send_remove_from_sock" > Revert "media: st-delta: Fix reference count leak in delta_run_work" > Revert "media: sti: Fix reference count leaks" > Revert "media: exynos4-is: Fix several reference count leaks due to > pm_runtime_get_sync" > Revert "media: exynos4-is: Fix a reference count leak due to > pm_runtime_get_sync" > Revert "media: exynos4-is: Fix a reference count leak" > Revert "media: ti-vpe: Fix a missing check and reference count leak" > Revert "media: stm32-dcmi: Fix a reference count leak" > Revert "media: s5p-mfc: Fix a reference count leak" > Revert "media: camss: Fix a reference count leak." > Revert "media: platform: fcp: Fix a reference count leak." > Revert "media: rockchip/rga: Fix a reference count leak." > Revert "media: rcar-vin: Fix a reference count leak." > Revert "media: rcar-vin: Fix a reference count leak." > Revert "firmware: Fix a reference count leak." > Revert "drm/nouveau: fix reference count leak in > nouveau_debugfs_strap_peek" > Revert "drm/nouveau: fix reference count leak in > nv50_disp_atomic_commit" > Revert "drm/nouveau: fix multiple instances of reference count leaks" > Revert "drm/nouveau/drm/noveau: fix reference count leak in > nouveau_fbcon_open" > Revert "PCI: Fix pci_create_slot() reference count leak" > Revert "omapfb: fix multiple reference count leaks due to > pm_runtime_get_sync" > Revert "drm/radeon: Fix reference count leaks caused by > pm_runtime_get_sync" > Revert "drm/radeon: fix multiple reference count leak" > Revert "drm/amdkfd: Fix reference count leaks." I didn't review these carefully, but from a quick look they all seem rather inconsequental. Either error paths that are very unlikely, or drivers which are very dead (looking at the entire list, not just what you reverted here). Acked-by: Daniel Vetter <daniel.vetter(a)ffwll.ch> Also adding drm maintainers/lists, those aren't all on your cc it seems. I will also forward this to fd.o sitewranglers as abuse of our infrastructure, it's for community collaboration, not for inflicting experiments on unconsenting subjects. I'me dropping non-drm people here so not everyone gets spammed too badly. -Daniel > Revert "platform/chrome: cros_ec_ishtp: Fix a double-unlock issue" > Revert "usb: dwc3: pci: Fix reference count leak in > dwc3_pci_resume_work" > Revert "ASoC: rockchip: Fix a reference count leak." > Revert "RDMA/rvt: Fix potential memory leak caused by rvt_alloc_rq" > Revert "EDAC: Fix reference count leaks" > Revert "ASoC: tegra: Fix reference count leaks." > Revert "test_objagg: Fix potential memory leak in error handling" > Revert "ASoC: img-parallel-out: Fix a reference count leak" > Revert "ASoC: img: Fix a reference count leak in img_i2s_in_set_fmt" > Revert "efi/esrt: Fix reference count leak in > esre_create_sysfs_entry." > Revert "scsi: iscsi: Fix reference count leak in > iscsi_boot_create_kobj" > Revert "vfio/mdev: Fix reference count leak in > add_mdev_supported_type" > Revert "RDMA/core: Fix several reference count leaks." > Revert "cpuidle: Fix three reference count leaks" > Revert "iommu: Fix reference count leak in iommu_group_alloc." > Revert "ACPI: CPPC: Fix reference count leak in > acpi_cppc_processor_probe()" > Revert "ACPI: sysfs: Fix reference count leak in > acpi_sysfs_add_hotplug_profile()" > Revert "ASoC: fix incomplete error-handling in img_i2s_in_probe." > Revert "qlcnic: fix missing release in qlcnic_83xx_interrupt_test." > Revert "RDMA/pvrdma: Fix missing pci disable in pvrdma_pci_probe()" > Revert "usb: gadget: fix potential double-free in m66592_probe." > Revert "net/mlx4_core: fix a memory leak bug." > Revert "rxrpc: Fix a memory leak in rxkad_verify_response()" > Revert "net: sun: fix missing release regions in cas_init_one()." > Revert "agp/intel: Fix a memory leak on module initialisation failure" > Revert "nfp: abm: fix a memory leak bug" > Revert "power: supply: core: fix memory leak in HWMON error path" > Revert "media: media/saa7146: fix incorrect assertion in > saa7146_buffer_finish" > Revert "ecryptfs: replace BUG_ON with error handling code" > Revert "clk: samsung: Remove redundant check in > samsung_cmu_register_one" > Revert "fs: ocfs: remove unnecessary assertion in dlm_migrate_lockres" > Revert "media: davinci/vpfe_capture.c: Avoid BUG_ON for register > failure" > Revert "media: saa7146: Avoid using BUG_ON as an assertion" > Revert "media: cx231xx: replace BUG_ON with recovery code" > Revert "RDMA/srpt: Remove unnecessary assertion in > srpt_queue_response" > Revert "staging: kpc2000: remove unnecessary assertions in > kpc_dma_transfer" > Revert "xen/grant-table: remove multiple BUG_ON on gnttab_interface" > Revert "scsi: libfc: remove unnecessary assertion on ep variable" > Revert "hdlcdrv: replace unnecessary assertion in hdlcdrv_register" > Revert "nfc: s3fwrn5: replace the assertion with a WARN_ON" > Revert "nfsd: remove unnecessary assertion in nfsd4_encode_replay" > Revert "bpf: Remove unnecessary assertion on fp_old" > Revert "net: caif: replace BUG_ON with recovery code" > Revert "fore200e: Fix incorrect checks of NULL pointer dereference" > Revert "mac80211: Remove redundant assertion" > Revert "rfkill: Fix incorrect check to avoid NULL pointer dereference" > Revert "pppoe: remove redundant BUG_ON() check in pppoe_pernet" > Revert "net: atm: Reduce the severity of logging in unlink_clip_vcc" > Revert "media: rcar_drif: fix a memory disclosure" > Revert "drm/gma500: fix memory disclosures due to uninitialized bytes" > Revert "gma/gma500: fix a memory disclosure bug due to uninitialized > bytes" > Revert "net: ixgbevf: fix a missing check of > ixgbevf_write_msg_read_ack" > Revert "rapidio: fix a NULL pointer dereference when > create_workqueue() fails" > Revert "ASoC: cs43130: fix a NULL pointer dereference" > Revert "ASoC: rt5645: fix a NULL pointer dereference" > Revert "ALSA: usx2y: fix a double free bug" > Revert "tracing: Fix a memory leak by early error exit in > trace_pid_write()" > Revert "rsi: Fix NULL pointer dereference in kmalloc" > Revert "net: cw1200: fix a NULL pointer dereference" > Revert "net: ieee802154: fix missing checks for regmap_update_bits" > Revert "audit: fix a memory leak bug" > Revert "x86/PCI: Fix PCI IRQ routing table memory leak" > Revert "udf: fix an uninitialized read bug and remove dead code" > Revert "mmc_spi: add a status check for spi_sync_locked" > Revert "PCI: endpoint: Fix a potential NULL pointer dereference" > Revert "net/smc: fix a NULL pointer dereference" > Revert "pinctrl: axp209: Fix NULL pointer dereference after > allocation" > Revert "power: charger-manager: fix a potential NULL pointer > dereference" > Revert "iio: hmc5843: fix potential NULL pointer dereferences" > Revert "iio: adc: fix a potential NULL pointer dereference" > Revert "rtlwifi: fix a potential NULL pointer dereference" > Revert "net: mwifiex: fix a NULL pointer dereference" > Revert "video: imsttfb: fix potential NULL pointer dereferences" > Revert "video: hgafb: fix potential NULL pointer dereference" > Revert "omapfb: Fix potential NULL pointer dereference in kmalloc" > Revert "staging: greybus: audio_manager: fix a missing check of > ida_simple_get" > Revert "PCI: xilinx: Check for __get_free_pages() failure" > Revert "media: video-mux: fix null pointer dereferences" > Revert "thunderbolt: property: Fix a missing check of kzalloc" > Revert "char: hpet: fix a missing check of ioremap" > Revert "libnvdimm/btt: Fix a kmemdup failure check" > Revert "tty: ipwireless: fix missing checks for ioremap" > Revert "RDMA/i40iw: Handle workqueue allocation failure" > Revert "usb: u132-hcd: fix potential NULL pointer dereference" > Revert "usb: sierra: fix a missing check of device_create_file" > Revert "scsi: qla4xxx: fix a potential NULL pointer dereference" > Revert "gpio: aspeed: fix a potential NULL pointer dereference" > Revert "libnvdimm/namespace: Fix a potential NULL pointer dereference" > Revert "x86/hpet: Prevent potential NULL pointer dereference" > Revert "staging: rtl8188eu: Fix potential NULL pointer dereference of > kcalloc" > Revert "thunderbolt: Fix a missing check of kmemdup" > Revert "thunderbolt: property: Fix a NULL pointer dereference" > Revert "media: si2165: fix a missing check of return value" > Revert "scsi: ufs: fix a missing check of devm_reset_control_get" > Revert "tty: mxs-auart: fix a potential NULL pointer dereference" > Revert "tty: atmel_serial: fix a potential NULL pointer dereference" > Revert "serial: mvebu-uart: Fix to avoid a potential NULL pointer > dereference" > Revert "HID: logitech: check the return value of > create_singlethread_workqueue" > Revert "netfilter: ip6t_srh: fix NULL pointer dereferences" > Revert "spi : spi-topcliff-pch: Fix to handle empty DMA buffers" > Revert "net: tipc: fix a missing check of nla_nest_start" > Revert "net: openvswitch: fix a NULL pointer dereference" > Revert "ALSA: sb8: add a check for request_region" > Revert "net: strparser: fix a missing check for > create_singlethread_workqueue" > Revert "qlcnic: Avoid potential NULL pointer dereference" > Revert "ALSA: usx2y: Fix potential NULL pointer dereference" > Revert "net: 8390: fix potential NULL pointer dereferences" > Revert "net: fujitsu: fix a potential NULL pointer dereference" > Revert "net: qlogic: fix a potential NULL pointer dereference" > Revert "md: Fix failed allocation of md_register_thread" > Revert "net: rocker: fix a potential NULL pointer dereference" > Revert "net: thunder: fix a potential NULL pointer dereference" > Revert "net: lio_core: fix two NULL pointer dereferences" > Revert "net: liquidio: fix a NULL pointer dereference" > Revert "isdn: mISDNinfineon: fix potential NULL pointer dereference" > Revert "isdn: mISDN: Fix potential NULL pointer dereference of > kzalloc" > Revert "libertas: add checks for the return value of > sysfs_create_group" > Revert "rtc: hym8563: fix a missing check of block data read" > Revert "power: twl4030: fix a missing check of return value" > Revert "misc/ics932s401: Add a missing check to > i2c_smbus_read_word_data" > Revert "leds: lp5523: fix a missing check of return value of > lp55xx_read" > Revert "media: dvb: Add check on sp8870_readreg" > Revert "media: dvb: add return value check on Write16" > Revert "media: mt312: fix a missing check of mt312 reset" > Revert "media: lgdt3306a: fix a missing check of return value" > Revert "media: gspca: mt9m111: Check write_bridge for timeout" > Revert "media: gspca: Check the return value of write_bridge for > timeout" > Revert "media: usb: gspca: add a missed check for goto_low_power" > Revert "media: usb: gspca: add a missed return-value check for > do_command" > Revert "ath6kl: return error code in ath6kl_wmi_set_roam_lrssi_cmd()" > Revert "brcmfmac: add a check for the status of usb_register" > Revert "serial: max310x: pass return value of spi_register_driver" > Revert "Input: ad7879 - add check for read errors in interrupt" > Revert "ALSA: sb: fix a missing check of snd_ctl_add" > Revert "ALSA: gus: add a check of the status of snd_ctl_add" > Revert "Staging: rts5208: Fix error handling on rtsx_send_cmd" > Revert "staging: rts5208: Add a check for ms_read_extra_data" > Revert "dmaengine: qcom_hidma: Check for driver register failure" > Revert "dmaengine: mv_xor: Fix a missing check in mv_xor_channel_add" > Revert "iio: ad9523: fix a missing check of return value" > Revert "mfd: mc13xxx: Fix a missing check of a register-read failure" > Revert "infiniband: bnxt_re: qplib: Check the return value of > send_message" > Revert "gdrom: fix a memory leak bug" > Revert "net: marvell: fix a missing check of acpi_match_device" > Revert "atl1e: checking the status of atl1e_write_phy_reg" > Revert "net: dsa: bcm_sf2: Propagate error value from mdio_write" > Revert "net: stmicro: fix a missing check of clk_prepare" > Revert "net: (cpts) fix a missing check of clk_prepare" > Revert "niu: fix missing checks of niu_pci_eeprom_read" > Revert "net: chelsio: Add a missing check on cudg_get_buffer" > Revert "ipv6/route: Add a missing check on proc_dointvec" > Revert "net/net_namespace: Check the return value of > register_pernet_subsys()" > Revert "hwmon: (lm80) fix a missing check of bus read in lm80 probe" > Revert "net: netxen: fix a missing check and an uninitialized use" > Revert "drivers/regulator: fix a missing check of return value" > Revert "net: socket: fix a missing-check bug" > Revert "dm ioctl: harden copy_params()'s copy_from_user() from > malicious users" > Revert "ethtool: fix a missing-check bug" > Revert "media: isif: fix a NULL pointer dereference bug" > Revert "yam: fix a missing-check bug" > Revert "net: cxgb3_main: fix a missing-check bug" > Revert "virt: vbox: Only copy_from_user the request-header once" > Revert "ALSA: control: fix a redundant-copy issue" > Revert "scsi: 3w-xxxx: fix a missing-check bug" > Revert "scsi: 3w-9xxx: fix a missing-check bug" > Revert "ethtool: fix a potential missing-check bug" > > arch/x86/kernel/hpet.c | 2 -- > arch/x86/pci/irq.c | 10 ++---- > drivers/acpi/cppc_acpi.c | 1 - > drivers/acpi/sysfs.c | 4 +-- > drivers/atm/fore200e.c | 25 +++++---------- > drivers/cdrom/gdrom.c | 1 - > drivers/char/agp/intel-gtt.c | 4 +-- > drivers/char/hpet.c | 2 -- > drivers/clk/samsung/clk.c | 4 +++ > drivers/cpuidle/sysfs.c | 6 ++-- > drivers/dma/mv_xor.c | 5 +-- > drivers/dma/qcom/hidma_mgmt.c | 3 +- > drivers/edac/edac_device_sysfs.c | 1 - > drivers/edac/edac_pci_sysfs.c | 2 +- > drivers/firmware/efi/esrt.c | 2 +- > drivers/firmware/qemu_fw_cfg.c | 7 ++--- > drivers/gpio/gpio-aspeed.c | 2 -- > drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 20 +++--------- > drivers/gpu/drm/gma500/cdv_intel_display.c | 2 -- > drivers/gpu/drm/gma500/oaktrail_crtc.c | 2 -- > drivers/gpu/drm/nouveau/dispnv50/disp.c | 4 +-- > drivers/gpu/drm/nouveau/nouveau_debugfs.c | 4 +-- > drivers/gpu/drm/nouveau/nouveau_drm.c | 8 ++--- > drivers/gpu/drm/nouveau/nouveau_fbcon.c | 4 +-- > drivers/gpu/drm/nouveau/nouveau_gem.c | 4 +-- > drivers/gpu/drm/radeon/radeon_connectors.c | 20 +++--------- > drivers/gpu/drm/radeon/radeon_display.c | 4 +-- > drivers/gpu/drm/radeon/radeon_drv.c | 4 +-- > drivers/gpu/drm/radeon/radeon_kms.c | 4 +-- > drivers/hid/hid-logitech-hidpp.c | 8 +---- > drivers/hwmon/lm80.c | 11 ++----- > drivers/iio/adc/mxs-lradc-adc.c | 2 -- > drivers/iio/frequency/ad9523.c | 7 ++--- > drivers/iio/magnetometer/hmc5843_i2c.c | 7 +---- > drivers/iio/magnetometer/hmc5843_spi.c | 7 +---- > drivers/infiniband/core/sysfs.c | 10 +++--- > drivers/infiniband/hw/bnxt_re/qplib_sp.c | 5 +-- > drivers/infiniband/hw/i40iw/i40iw.h | 2 +- > drivers/infiniband/hw/i40iw/i40iw_cm.c | 18 ++--------- > drivers/infiniband/hw/i40iw/i40iw_main.c | 5 +-- > .../infiniband/hw/vmw_pvrdma/pvrdma_main.c | 2 +- > drivers/infiniband/sw/rdmavt/qp.c | 6 ++-- > drivers/infiniband/ulp/srpt/ib_srpt.c | 2 ++ > drivers/input/touchscreen/ad7879.c | 11 +++---- > drivers/iommu/iommu.c | 2 +- > drivers/isdn/hardware/mISDN/hfcsusb.c | 3 -- > drivers/isdn/hardware/mISDN/mISDNinfineon.c | 5 +-- > drivers/leds/leds-lp5523.c | 4 +-- > drivers/md/dm-ioctl.c | 18 +++++++---- > drivers/md/raid10.c | 2 -- > drivers/md/raid5.c | 2 -- > drivers/media/common/saa7146/saa7146_fops.c | 2 ++ > drivers/media/common/saa7146/saa7146_video.c | 6 ++-- > drivers/media/dvb-frontends/drxd_hard.c | 30 +++++++----------- > drivers/media/dvb-frontends/lgdt3306a.c | 5 +-- > drivers/media/dvb-frontends/mt312.c | 4 +-- > drivers/media/dvb-frontends/si2165.c | 8 ++--- > drivers/media/dvb-frontends/sp8870.c | 4 +-- > drivers/media/platform/davinci/isif.c | 3 +- > drivers/media/platform/davinci/vpfe_capture.c | 31 +++++++++---------- > drivers/media/platform/exynos4-is/fimc-isp.c | 4 +-- > drivers/media/platform/exynos4-is/fimc-lite.c | 2 +- > drivers/media/platform/exynos4-is/media-dev.c | 4 +-- > drivers/media/platform/exynos4-is/mipi-csis.c | 4 +-- > .../media/platform/qcom/camss/camss-csiphy.c | 4 +-- > drivers/media/platform/rcar-fcp.c | 4 +-- > drivers/media/platform/rcar-vin/rcar-dma.c | 4 +-- > drivers/media/platform/rcar-vin/rcar-v4l2.c | 4 +-- > drivers/media/platform/rcar_drif.c | 1 - > drivers/media/platform/rockchip/rga/rga-buf.c | 1 - > drivers/media/platform/s5p-mfc/s5p_mfc_pm.c | 4 +-- > drivers/media/platform/sti/delta/delta-v4l2.c | 4 +-- > drivers/media/platform/sti/hva/hva-hw.c | 2 -- > drivers/media/platform/stm32/stm32-dcmi.c | 4 ++- > drivers/media/platform/ti-vpe/vpe.c | 2 -- > drivers/media/platform/video-mux.c | 5 --- > drivers/media/usb/cx231xx/cx231xx-i2c.c | 3 +- > drivers/media/usb/gspca/cpia1.c | 14 ++------- > drivers/media/usb/gspca/m5602/m5602_mt9m111.c | 8 ++--- > drivers/media/usb/gspca/m5602/m5602_po1030.c | 8 ++--- > drivers/mfd/mc13xxx-core.c | 4 +-- > drivers/misc/ics932s401.c | 2 -- > drivers/mmc/host/mmc_spi.c | 4 --- > drivers/net/caif/caif_serial.c | 4 +-- > drivers/net/dsa/bcm_sf2.c | 7 +++-- > drivers/net/ethernet/8390/pcnet_cs.c | 10 ------ > .../net/ethernet/atheros/atl1e/atl1e_main.c | 4 +-- > .../net/ethernet/cavium/liquidio/lio_core.c | 10 ------ > .../net/ethernet/cavium/liquidio/lio_main.c | 5 --- > .../net/ethernet/cavium/thunder/nicvf_main.c | 6 ---- > .../net/ethernet/chelsio/cxgb3/cxgb3_main.c | 17 ---------- > .../net/ethernet/chelsio/cxgb4/cudbg_lib.c | 4 --- > drivers/net/ethernet/fujitsu/fmvj18x_cs.c | 5 --- > drivers/net/ethernet/intel/ixgbevf/vf.c | 5 +-- > .../net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 -- > drivers/net/ethernet/mellanox/mlx4/fw.c | 2 +- > drivers/net/ethernet/netronome/nfp/abm/main.c | 1 - > .../ethernet/qlogic/netxen/netxen_nic_init.c | 3 +- > drivers/net/ethernet/qlogic/qla3xxx.c | 6 ---- > .../ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 4 +-- > .../ethernet/qlogic/qlcnic/qlcnic_ethtool.c | 2 -- > drivers/net/ethernet/rocker/rocker_main.c | 5 --- > .../net/ethernet/stmicro/stmmac/dwmac-sunxi.c | 4 +-- > drivers/net/ethernet/sun/cassini.c | 3 +- > drivers/net/ethernet/sun/niu.c | 10 ++---- > drivers/net/ethernet/ti/cpts.c | 4 +-- > drivers/net/hamradio/hdlcdrv.c | 2 ++ > drivers/net/hamradio/yam.c | 4 --- > drivers/net/ieee802154/mcr20a.c | 6 ---- > drivers/net/ppp/pppoe.c | 2 ++ > drivers/net/wireless/ath/ath6kl/wmi.c | 4 ++- > .../broadcom/brcm80211/brcmfmac/usb.c | 6 +--- > drivers/net/wireless/marvell/libertas/mesh.c | 5 --- > drivers/net/wireless/marvell/mwifiex/cmdevt.c | 6 ---- > drivers/net/wireless/realtek/rtlwifi/base.c | 5 --- > drivers/net/wireless/rsi/rsi_91x_mac80211.c | 30 +++++++----------- > drivers/net/wireless/st/cw1200/main.c | 5 --- > drivers/nfc/s3fwrn5/firmware.c | 5 +-- > drivers/nvdimm/btt_devs.c | 18 +++-------- > drivers/nvdimm/namespace_devs.c | 5 +-- > drivers/pci/controller/pcie-xilinx.c | 12 ++----- > drivers/pci/endpoint/functions/pci-epf-test.c | 5 --- > drivers/pci/slot.c | 6 ++-- > drivers/pinctrl/pinctrl-axp209.c | 2 -- > drivers/platform/chrome/cros_ec_ishtp.c | 4 +-- > drivers/power/supply/charger-manager.c | 3 -- > drivers/power/supply/power_supply_hwmon.c | 2 +- > drivers/power/supply/twl4030_charger.c | 4 +-- > drivers/rapidio/rio_cm.c | 8 ----- > drivers/regulator/palmas-regulator.c | 5 +-- > drivers/rtc/rtc-hym8563.c | 2 -- > drivers/scsi/3w-9xxx.c | 5 --- > drivers/scsi/3w-xxxx.c | 3 -- > drivers/scsi/iscsi_boot_sysfs.c | 2 +- > drivers/scsi/qla4xxx/ql4_os.c | 2 -- > drivers/scsi/ufs/ufs-hisi.c | 4 --- > drivers/spi/spi-topcliff-pch.c | 15 ++------- > drivers/staging/greybus/audio_manager.c | 3 -- > drivers/staging/kpc2000/kpc_dma/fileops.c | 2 ++ > drivers/staging/rtl8188eu/core/rtw_xmit.c | 9 ++---- > drivers/staging/rtl8188eu/include/rtw_xmit.h | 2 +- > drivers/staging/rtl8723bs/core/rtw_xmit.c | 14 ++++----- > drivers/staging/rtl8723bs/include/rtw_xmit.h | 2 +- > drivers/staging/rts5208/ms.c | 5 +-- > drivers/staging/rts5208/sd.c | 7 +---- > drivers/target/tcm_fc/tfc_io.c | 1 + > drivers/thunderbolt/property.c | 16 +--------- > drivers/tty/ipwireless/main.c | 8 ----- > drivers/tty/serial/atmel_serial.c | 4 --- > drivers/tty/serial/max310x.c | 4 +-- > drivers/tty/serial/mvebu-uart.c | 3 -- > drivers/tty/serial/mxs-auart.c | 4 --- > drivers/usb/dwc3/dwc3-pci.c | 4 +-- > drivers/usb/gadget/udc/m66592-udc.c | 2 +- > drivers/usb/host/u132-hcd.c | 2 -- > drivers/usb/storage/sierra_ms.c | 4 ++- > drivers/vfio/mdev/mdev_sysfs.c | 2 +- > drivers/video/fbdev/hgafb.c | 2 -- > drivers/video/fbdev/imsttfb.c | 5 --- > drivers/video/fbdev/omap2/omapfb/dss/dispc.c | 7 ++--- > drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 7 ++--- > drivers/video/fbdev/omap2/omapfb/dss/dss.c | 7 ++--- > drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c | 5 ++- > drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c | 5 ++- > .../omap2/omapfb/dss/omapdss-boot-init.c | 2 -- > drivers/video/fbdev/omap2/omapfb/dss/venc.c | 7 ++--- > drivers/virt/vboxguest/vboxguest_linux.c | 4 +-- > drivers/xen/grant-table.c | 4 +++ > fs/ecryptfs/crypto.c | 6 ++-- > fs/nfsd/nfs4xdr.c | 2 ++ > fs/ocfs2/dlm/dlmmaster.c | 2 ++ > fs/udf/namei.c | 15 +++++++++ > kernel/auditfilter.c | 12 +++---- > kernel/bpf/core.c | 2 ++ > kernel/trace/trace.c | 5 +-- > lib/test_objagg.c | 4 +-- > net/atm/clip.c | 6 ++-- > net/core/net_namespace.c | 3 +- > net/ethtool/ioctl.c | 8 ----- > net/ipv6/netfilter/ip6t_srh.c | 6 ---- > net/ipv6/route.c | 6 +--- > net/mac80211/util.c | 1 + > net/openvswitch/datapath.c | 4 --- > net/rds/message.c | 1 - > net/rds/send.c | 2 +- > net/rfkill/core.c | 7 ++--- > net/rxrpc/rxkad.c | 2 +- > net/smc/smc_ism.c | 5 --- > net/socket.c | 11 ++----- > net/strparser/strparser.c | 2 -- > net/tipc/group.c | 3 -- > sound/core/control_compat.c | 3 +- > sound/isa/gus/gus_main.c | 13 ++------ > sound/isa/sb/sb16_main.c | 10 ++---- > sound/isa/sb/sb8.c | 4 --- > sound/soc/codecs/cs43130.c | 2 -- > sound/soc/codecs/rt5645.c | 3 -- > sound/soc/img/img-i2s-in.c | 5 +-- > sound/soc/img/img-parallel-out.c | 4 +-- > sound/soc/rockchip/rockchip_pdm.c | 4 +-- > sound/soc/tegra/tegra30_ahub.c | 4 +-- > sound/soc/tegra/tegra30_i2s.c | 4 +-- > sound/usb/usx2y/usb_stream.c | 5 --- > sound/usb/usx2y/usbusx2y.c | 4 ++- > 204 files changed, 306 insertions(+), 826 deletions(-) > > -- > 2.31.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

3 2

[PATCH v8 0/5] drm: Move struct drm_device.pdev to legacy
by Thomas Zimmermann 29 Apr '21

29 Apr '21

V8 of the patchset fixes more bitrot and some commit messages. The pdev field in struct drm_device points to a PCI device structure and goes back to UMS-only days when all DRM drivers were for PCI devices. Meanwhile we also support USB, SPI and platform devices. Each of those uses the generic device stored in struct drm_device.dev. To reduce duplication and remove the special case of PCI, this patchset converts all modesetting drivers from pdev to dev and makes pdev a field for legacy UMS drivers. For PCI devices, the pointer in struct drm_device.dev can be upcasted to struct pci_device; or tested for PCI with dev_is_pci(). In several places the code can use the dev field directly. After converting all drivers and the DRM core, the pdev fields becomes only relevant for legacy drivers. In a later patchset, we may want to convert these as well and remove pdev entirely. v8: * fix pdev bitrot in ast * fix commit messages (Michael) v7: * fix instances of pdev that have benn added under i915/ v6: * also remove assignment in i915/selftests in later patch (Chris) v5: * remove assignment in later patch (Chris) v4: * merged several patches * moved core changes into separate patch * vmwgfx build fix v3: * merged several patches * fix one pdev reference in nouveau (Jeremy) * rebases v2: * move whitespace fixes into separate patches (Alex, Sam) * move i915 gt/ and gvt/ changes into separate patches (Joonas) Thomas Zimmermann (5): drm/ast: Remove reference to struct drm_device.pdev drm/i915/gt: Remove reference to struct drm_device.pdev drm/i915: Remove reference to struct drm_device.pdev drm/i915: Don't assign to struct drm_device.pdev drm: Move struct drm_device.pdev to legacy section drivers/gpu/drm/ast/ast_main.c | 1 - drivers/gpu/drm/i915/gt/intel_region_lmem.c | 2 +- drivers/gpu/drm/i915/i915_drv.c | 1 - drivers/gpu/drm/i915/intel_runtime_pm.h | 2 +- drivers/gpu/drm/i915/selftests/mock_gem_device.c | 1 - include/drm/drm_device.h | 6 +++--- 6 files changed, 5 insertions(+), 8 deletions(-) base-commit: bf25e1addaf44137e20ce95de72ff118b37d808c prerequisite-patch-id: c2b2f08f0eccc9f5df0c0da49fa1d36267deb11d prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24 prerequisite-patch-id: c59ca2ddb182af06006fa360ad3e90fe16b93d3a -- 2.31.1

2 9

[PATCH 00/25] drm/i915/gem: ioctl clean-ups (v4)
by Jason Ekstrand 29 Apr '21

29 Apr '21

Overview: --------- This patch series attempts to clean up some of the IOCTL mess we've created over the last few years. The most egregious bit being context mutability. In summary, this series: 1. Drops two never-used context params: RINGSIZE and NO_ZEROMAP 2. Drops the entire CONTEXT_CLONE API 3. Implements SINGLE_TIMELINE with a syncobj instead of actually sharing intel_timeline between engines. 4. Adds a few sanity restrictions to the balancing/bonding API. 5. Implements a proto-ctx mechanism so that the engine set and VM can only be set early on in the lifetime of a context, before anything ever executes on it. This effectively makes the VM and engine set immutable. This series has been tested with IGT as well as the Iris, ANV, and the Intel media driver doing an 8K decode (this uses bonding/balancing). I've also done quite a bit of git archeology to ensure that nothing in here will break anything that's already shipped at some point in history. It's possible I've missed something, but I've dug quite a bit. Details and motivation: ----------------------- In very broad strokes, there's an effort going on right now within Intel to try and clean up and simplify i915 anywhere we can. We obviously don't want to break any shipping userspace but, as can be seen by this series, there's a lot i915 theoretically supports which userspace doesn't actually need. Some of this, like the two context params used here, were simply oversights where we went through the usual API review process and merged the i915 bits but the userspace bits never landed for some reason. Not all are so innocent, however. For instance, there's an entire context cloning API which allows one to create a context with certain parameters "cloned" from some other context. This entire API has never been used by any userspace except IGT and there were never patches to any other userspace to use it. It never should have landed. Also, when we added support for setting explicit engine sets and sharing VMs across contexts, people decided to do so via SET_CONTEXT_PARAM. While this allowed them to re-use existing API, it did so at the cost of making those states mutable which leads to a plethora of potential race conditions. There were even IGT tests merged to cover some of theses: - gem_vm_create@async-destroy and gem_vm_create@destroy-race which test swapping out the VM on a running context. - gem_ctx_persistence@replace* which test whether a client can escape a non-persistent context by submitting a hanging batch and then swapping out the engine set before the hang is detected. - api_intel_bb@bb-with-vm which tests the that intel_bb_assign_vm works properly. This API is never used by any other IGT test. There is also an entire deferred flush and set state framework in i915_gem_cotnext.c which exists for safely swapping out the VM while there is work in-flight on a context. So, clearly people knew that this API was inherently racy and difficult to implement but they landed it anyway. Why? The best explanation I've been given is because it makes the API more "unified" or "symmetric" for this stuff to go through SET_CONTEXT_PARAM. It's not because any userspace actually wants to be able to swap out the VM or the set of engines on a running context. That would be utterly insane. This patch series cleans up this particular mess by introducing the concept of a i915_gem_proto_context data structure which contains context creation information. When you initially call GEM_CONTEXT_CREATE, a proto-context in created instead of an actual context. Then, the first time something is done on the context besides SET_CONTEXT_PARAM, an actual context is created. This allows us to keep the old drivers which use SET_CONTEXT_PARAM to set up the engine set (see also media) while ensuring that, once you have an i915_gem_context, the VM and the engine set are immutable state. Eventually, there are more clean-ups I'd like to do on top of this which should make working with contexts inside i915 simpler and safer: 1. Move the GEM handle -> vma LUT from i915_gem_context into either i915_ppgtt or drm_i915_file_private depending on whether or not the hardware has a full PPGTT. 2. Move the delayed context destruction code into intel_context or a per-engine wrapper struct rather than i915_gem_context. 3. Get rid of the separation between context close and context destroy 4. Get rid of the RCU on i915_gem_context However, these should probably be done as a separate patch series as this one is already starting to get longish, especially if you consider the 89 IGT patches that go along with it. Test-with: 20210423214853.876911-1-jason(a)jlekstrand.net Jason Ekstrand (25): drm/i915: Drop I915_CONTEXT_PARAM_RINGSIZE drm/i915: Stop storing the ring size in the ring pointer drm/i915: Drop I915_CONTEXT_PARAM_NO_ZEROMAP drm/i915/gem: Set the watchdog timeout directly in intel_context_set_gem (v2) drm/i915/gem: Return void from context_apply_all drm/i915: Drop the CONTEXT_CLONE API drm/i915: Implement SINGLE_TIMELINE with a syncobj (v4) drm/i915: Drop getparam support for I915_CONTEXT_PARAM_ENGINES drm/i915/gem: Disallow bonding of virtual engines (v3) drm/i915/gem: Remove engine auto-magic with FENCE_SUBMIT drm/i915/request: Remove the hook from await_execution drm/i915/gem: Disallow creating contexts with too many engines drm/i915: Stop manually RCU banging in reset_stats_ioctl (v2) drm/i915/gem: Add a separate validate_priority helper drm/i915: Add gem/i915_gem_context.h to the docs drm/i915/gem: Add an intermediate proto_context struct drm/i915/gem: Use the proto-context to handle create parameters drm/i915/gem: Return an error ptr from context_lookup drm/i915/gt: Drop i915_address_space::file (v2) drm/i915/gem: Delay context creation drm/i915/gem: Don't allow changing the VM on running contexts drm/i915/gem: Don't allow changing the engine set on running contexts drm/i915/selftests: Take a VM in kernel_context() i915/gem/selftests: Assign the VM at context creation in igt_shared_ctx_exec drm/i915/gem: Roll all of context creation together Documentation/gpu/i915.rst | 2 + drivers/gpu/drm/i915/Makefile | 1 - drivers/gpu/drm/i915/gem/i915_gem_context.c | 2978 +++++++---------- drivers/gpu/drm/i915/gem/i915_gem_context.h | 3 + .../gpu/drm/i915/gem/i915_gem_context_types.h | 192 +- .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 31 +- .../drm/i915/gem/selftests/i915_gem_context.c | 127 +- .../gpu/drm/i915/gem/selftests/mock_context.c | 63 +- .../gpu/drm/i915/gem/selftests/mock_context.h | 4 +- drivers/gpu/drm/i915/gt/intel_context.c | 3 +- drivers/gpu/drm/i915/gt/intel_context.h | 5 - drivers/gpu/drm/i915/gt/intel_context_param.c | 63 - drivers/gpu/drm/i915/gt/intel_context_param.h | 6 +- drivers/gpu/drm/i915/gt/intel_context_types.h | 1 + drivers/gpu/drm/i915/gt/intel_engine_types.h | 7 - .../drm/i915/gt/intel_execlists_submission.c | 114 - .../drm/i915/gt/intel_execlists_submission.h | 7 - drivers/gpu/drm/i915/gt/intel_gtt.h | 11 - drivers/gpu/drm/i915/gt/intel_lrc.c | 2 +- drivers/gpu/drm/i915/gt/selftest_execlists.c | 251 +- drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 2 +- drivers/gpu/drm/i915/gt/selftest_mocs.c | 2 +- drivers/gpu/drm/i915/gt/selftest_timeline.c | 2 +- drivers/gpu/drm/i915/gvt/scheduler.c | 7 +- drivers/gpu/drm/i915/i915_drv.h | 30 +- drivers/gpu/drm/i915/i915_perf.c | 4 +- drivers/gpu/drm/i915/i915_request.c | 42 +- drivers/gpu/drm/i915/i915_request.h | 4 +- .../drm/i915/selftests/i915_mock_selftests.h | 1 - drivers/gpu/drm/i915/selftests/mock_gtt.c | 1 - include/uapi/drm/i915_drm.h | 40 +- 31 files changed, 1584 insertions(+), 2422 deletions(-) delete mode 100644 drivers/gpu/drm/i915/gt/intel_context_param.c -- 2.31.1

1 25

[PATCH v2] drm/amd/amdgpu: Fix errors in documentation of function parameters
by Fabio M. De Francesco 29 Apr '21

29 Apr '21

In the documentation of functions, removed excess parameters, described undocumented ones, and fixed syntax errors. Signed-off-by: Fabio M. De Francesco <fmdefrancesco(a)gmail.com> --- Changes from v1: Cc'ed all the maintainers. drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 12 ++++++------ drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c | 4 +++- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c | 8 ++++---- 3 files changed, 13 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c index 2e9b16fb3fcd..bf2939b6eb43 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c @@ -76,7 +76,7 @@ struct amdgpu_atif { /** * amdgpu_atif_call - call an ATIF method * - * @handle: acpi handle + * @atif: acpi handle * @function: the ATIF function to execute * @params: ATIF function params * @@ -166,7 +166,6 @@ static void amdgpu_atif_parse_functions(struct amdgpu_atif_functions *f, u32 mas /** * amdgpu_atif_verify_interface - verify ATIF * - * @handle: acpi handle * @atif: amdgpu atif struct * * Execute the ATIF_FUNCTION_VERIFY_INTERFACE ATIF function @@ -240,8 +239,7 @@ static acpi_handle amdgpu_atif_probe_handle(acpi_handle dhandle) /** * amdgpu_atif_get_notification_params - determine notify configuration * - * @handle: acpi handle - * @n: atif notification configuration struct + * @atif: acpi handle * * Execute the ATIF_FUNCTION_GET_SYSTEM_PARAMETERS ATIF function * to determine if a notifier is used and if so which one @@ -304,7 +302,7 @@ static int amdgpu_atif_get_notification_params(struct amdgpu_atif *atif) /** * amdgpu_atif_query_backlight_caps - get min and max backlight input signal * - * @handle: acpi handle + * @atif: acpi handle * * Execute the QUERY_BRIGHTNESS_TRANSFER_CHARACTERISTICS ATIF function * to determine the acceptable range of backlight values @@ -363,7 +361,7 @@ static int amdgpu_atif_query_backlight_caps(struct amdgpu_atif *atif) /** * amdgpu_atif_get_sbios_requests - get requested sbios event * - * @handle: acpi handle + * @atif: acpi handle * @req: atif sbios request struct * * Execute the ATIF_FUNCTION_GET_SYSTEM_BIOS_REQUESTS ATIF function @@ -899,6 +897,8 @@ void amdgpu_acpi_fini(struct amdgpu_device *adev) /** * amdgpu_acpi_is_s0ix_supported * + * @adev: amdgpu_device_pointer + * * returns true if supported, false if not. */ bool amdgpu_acpi_is_s0ix_supported(struct amdgpu_device *adev) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c index 5af464933976..98d31ebad9ce 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c @@ -111,6 +111,8 @@ static const char *amdkfd_fence_get_timeline_name(struct dma_fence *f) * a KFD BO and schedules a job to move the BO. * If fence is already signaled return true. * If fence is not signaled schedule a evict KFD process work item. + * + * @f: dma_fence */ static bool amdkfd_fence_enable_signaling(struct dma_fence *f) { @@ -131,7 +133,7 @@ static bool amdkfd_fence_enable_signaling(struct dma_fence *f) /** * amdkfd_fence_release - callback that fence can be freed * - * @fence: fence + * @f: dma_fence * * This function is called when the reference count becomes zero. * Drops the mm_struct reference and RCU schedules freeing up the fence. diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c index b43e68fc1378..ed3014fbb563 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c @@ -719,7 +719,7 @@ static void unlock_spi_csq_mutexes(struct amdgpu_device *adev) } /** - * @get_wave_count: Read device registers to get number of waves in flight for + * get_wave_count: Read device registers to get number of waves in flight for * a particular queue. The method also returns the VMID associated with the * queue. * @@ -755,19 +755,19 @@ static void get_wave_count(struct amdgpu_device *adev, int queue_idx, } /** - * @kgd_gfx_v9_get_cu_occupancy: Reads relevant registers associated with each + * kgd_gfx_v9_get_cu_occupancy: Reads relevant registers associated with each * shader engine and aggregates the number of waves that are in flight for the * process whose pasid is provided as a parameter. The process could have ZERO * or more queues running and submitting waves to compute units. * * @kgd: Handle of device from which to get number of waves in flight * @pasid: Identifies the process for which this query call is invoked - * @wave_cnt: Output parameter updated with number of waves in flight that + * @pasid_wave_cnt: Output parameter updated with number of waves in flight that * belong to process with given pasid * @max_waves_per_cu: Output parameter updated with maximum number of waves * possible per Compute Unit * - * @note: It's possible that the device has too many queues (oversubscription) + * Note: It's possible that the device has too many queues (oversubscription) * in which case a VMID could be remapped to a different PASID. This could lead * to an iaccurate wave count. Following is a high-level sequence: * Time T1: vmid = getVmid(); vmid is associated with Pasid P1 -- 2.31.1

3 2

← Newer
1
...
19
20
21
22
23
24
25
...
72
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

dri-devel April 2021